chore(deps): bump Rspack 1.6.4

[colinaaa]

Summary by CodeRabbit

• Chores
  • Updated Rspack tooling to newer minor releases (CLI and core bumped to 1.6.4; test-tools unchanged).
  • Deactivated the previous Android SDK manager dependency entry (kept as commented reference).
  • Simplified build flow by removing the in-tree habitat build and adding a patch-apply step before sync.
  • Build task inputs now include patch artifacts so patches are included in builds.
• Bug Fixes / Diagnostics
  • Enriched build/loader error messages and updated a few generated snapshots/comments for clearer diagnostics.

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).
• Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

[changeset-bot]

⚠️ No Changeset found

Latest commit: 609595e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

📝 Walkthrough

Walkthrough

Bumps @rspack/cli and @rspack/core versions in the workspace; comments out an active buildtools/android_sdk_manager DEPS entry and adds that patch to the benchx_cli build flow; removes in-tree habitat build steps; adds patches/* to Turbo build inputs; updates multiple rspack-generated test snapshots and diagnostic expected outputs.

Changes

Cohort / File(s)	Summary
Workspace manifest pnpm-workspace.yaml	Updated @rspack/cli and @rspack/core from 1.6.1 → 1.6.4; @rspack/test-tools remains 1.5.6.
DEPS patch packages/lynx/benchx_cli/patches/android_sdk_manager.diff	Replaced an active buildtools/android_sdk_manager HTTP dependency block in DEPS with a commented-out version (dependency made inactive); other DEPS entries unchanged.
Build script packages/lynx/benchx_cli/scripts/build.mjs	Removed in-tree habitat build and venv/pip steps; added git apply for android_sdk_manager.diff before syncing; switched sync invocation to tools/hab sync .; reordered flow accordingly.
Turbo inputs packages/lynx/benchx_cli/turbo.json	Added patches/* to the build task inputs (was ["scripts/build.mjs"], now ["scripts/build.mjs", "patches/*"]).
Rspack-generated tests & diagnostics packages/.../test/**/__snapshot__/**/rspack/*.snap.txt, packages/.../test/**/expected/rspack.txt	Multiple test snapshots and expected diagnostic outputs updated to reflect enriched loader provenance, changed import/annotation comments (/* ESM import */ → /* import */ or /* ESM default export */ → /* export default */), and minor hot-update asset size changes; no functional code changes. (Files include many under packages/webpack/.../test/... and packages/webpack/css-extract-webpack-plugin/test/....)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Heterogeneous changes: manifest, DEPS patch, build script, CI/task inputs, and many generated test snapshots.
• Review focus:
  • Correct path and application of android_sdk_manager.diff in build.mjs.
  • Ensure commenting out DEPS entry doesn't break dependent build flows or CI.
  • Verify removal of in-tree habitat steps and tools/hab invocation match environment expectations.
  • Confirm snapshot updates are expected (no behavioral regressions).

Possibly related PRs

• chore(deps): bump rspack v1.6.1 #1909 — Edits the same pnpm-workspace.yaml rspack entries to bump @rspack/cli and @rspack/core.
• chore(deps): bump Rspack 1.6.0-beta.1 #1904 — Also updates workspace Rspack dependency versions; likely overlapping change.
• ci(benchmark/react): enable list in benchmark #1635 — Modifies packages/lynx/benchx_cli/scripts/build.mjs (related build flow and patch/application changes).

Suggested labels

framework:React

Suggested reviewers

• PupilTong

Poem

🐇 I nudged a diff and hopped with glee,
Bumped versions, tucked a DEPS entry free.
I applied a patch, removed a shell,
Synced the tools and fixed the spell.
Little rabbit builds — all snug as can be. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the primary change: bumping Rspack from 1.6.1 to 1.6.4, which is the main modification evident in pnpm-workspace.yaml.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a335c0 and c287cf3.

📒 Files selected for processing (13)

• packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/rspack.txt (2 hunks)
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/1.snap.txt (2 hunks)
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/2.snap.txt (2 hunks)
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/hook/useContext/__snapshot__/rspack/1.snap.txt (2 hunks)
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/hook/useState/__snapshot__/rspack/1.snap.txt (2 hunks)
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt (2 hunks)
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/2.snap.txt (2 hunks)
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/recovery/__snapshot__/rspack/2.snap.txt (2 hunks)
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/1.snap.txt (2 hunks)
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt (2 hunks)
• packages/webpack/react-webpack-plugin/test/diagnostic/jsx/component/expected/rspack.txt (1 hunks)
• packages/webpack/react-webpack-plugin/test/diagnostic/jsx/namespace-name/expected/rspack.txt (1 hunks)
• packages/webpack/react-webpack-plugin/test/diagnostic/module-build-failed/errors/expected/rspack.txt (1 hunks)

✅ Files skipped from review due to trivial changes (6)

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/hook/useContext/snapshot/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/snapshot/rspack/2.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/recovery/snapshot/rspack/2.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/hook/useState/snapshot/rspack/1.snap.txt
• packages/webpack/react-webpack-plugin/test/diagnostic/jsx/component/expected/rspack.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/snapshot/rspack/1.snap.txt

🧰 Additional context used

🧠 Learnings (20)

📓 Common learnings

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

📚 Learning: 2025-10-29T10:28:27.519Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.

Applied to files:

• packages/webpack/react-webpack-plugin/test/diagnostic/module-build-failed/errors/expected/rspack.txt
• packages/webpack/react-webpack-plugin/test/diagnostic/jsx/namespace-name/expected/rspack.txt
• packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/rspack.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/1.snap.txt
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-09-23T08:54:39.966Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1670
File: packages/webpack/css-extract-webpack-plugin/test/hotCases/hot/hot-update-json/dual-thread/__snapshot__/index.css:6-8
Timestamp: 2025-09-23T08:54:39.966Z
Learning: In the lynx-stack CSS extract webpack plugin tests, many test fixture CSS files intentionally use invalid CSS syntax like `color: 'red';` with quoted values. The snapshots correctly reflect this invalid CSS from the source fixtures. To fix CSS validation issues, the source fixture files should be updated first, then snapshots regenerated, rather than manually editing snapshots.

Applied to files:

• packages/webpack/react-webpack-plugin/test/diagnostic/module-build-failed/errors/expected/rspack.txt
• packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/rspack.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/1.snap.txt
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-09-23T08:53:56.927Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1670
File: packages/webpack/css-extract-webpack-plugin/src/loader.ts:244-251
Timestamp: 2025-09-23T08:53:56.927Z
Learning: In webpack CSS extraction plugins, when storing per-module dependencies in a compiler-scoped map like cssModuleId2Deps, the map should not be reset at compilation start because in incremental compilation (watch mode/HMR), only changed files pass through the loader. Unchanged modules need their dependency information to persist between compilations so the plugin can access all modules' dependencies when generating CSS output.

Applied to files:

• packages/webpack/react-webpack-plugin/test/diagnostic/module-build-failed/errors/expected/rspack.txt
• packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/rspack.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/1.snap.txt
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-08-21T07:21:51.621Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1562
File: packages/react/transform/src/swc_plugin_snapshot/jsx_helpers.rs:261-283
Timestamp: 2025-08-21T07:21:51.621Z
Learning: In packages/react/transform/src/swc_plugin_snapshot/jsx_helpers.rs, the team prefers to keep the original unreachable! logic for JSXSpreadChild in jsx_is_children_full_dynamic function rather than implementing defensive error handling.

Applied to files:

• packages/webpack/react-webpack-plugin/test/diagnostic/module-build-failed/errors/expected/rspack.txt
• packages/webpack/react-webpack-plugin/test/diagnostic/jsx/namespace-name/expected/rspack.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-08-06T13:28:57.182Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.

Applied to files:

• packages/webpack/react-webpack-plugin/test/diagnostic/module-build-failed/errors/expected/rspack.txt

📚 Learning: 2025-08-19T11:25:36.127Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).

Applied to files:

• packages/webpack/react-webpack-plugin/test/diagnostic/jsx/namespace-name/expected/rspack.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-09-18T04:43:54.426Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-09-18T04:43:54.426Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-11-04T10:15:14.965Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt
• packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-08-27T12:42:01.095Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-08-12T16:09:32.413Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-08-21T08:46:54.494Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-08-13T11:46:43.737Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-08-27T08:10:09.932Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-08-11T05:57:18.212Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-08-13T09:20:00.936Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1502
File: packages/react/testing-library/types/entry.d.ts:71-71
Timestamp: 2025-08-13T09:20:00.936Z
Learning: In lynx-js/react testing library, wrapper components must have children as a required prop because they are always called with `h(WrapperComponent, null, innerElement)` where innerElement is passed as children. The type `React.JSXElementConstructor<{ children: React.ReactNode }>` correctly requires children to be mandatory.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

📚 Learning: 2025-07-18T04:27:18.291Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.

Applied to files:

• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt
• packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt

🔇 Additional comments (9)

packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/value/__snapshot__/rspack/2.snap.txt (1)

9-9: Auto-generated snapshot regenerated correctly with Rspack 1.6.4.

The snapshot has been regenerated with Rspack 1.6.4, which slightly changed the import comment annotation from /* ESM import */ to /* import */ (line 46). This is a non-functional change—the generated code behavior and runtime execution remain identical. The asset size reduction (3448 → 3444 bytes) directly corresponds to the 4-byte comment shortening. This is expected when upgrading the build tool version.

Also applies to: 46-46

packages/webpack/react-webpack-plugin/test/diagnostic/jsx/namespace-name/expected/rspack.txt (1)

2-2: Test expectation correctly updated for Rspack 1.6.4 diagnostic enhancements.

The loader-scoped error message format change is expected for the Rspack version bump and aligns with enhanced error diagnostics that now include loader context. The change is consistent with the pattern observed in other diagnostic expectation files.

packages/webpack/react-webpack-plugin/test/diagnostic/module-build-failed/errors/expected/rspack.txt (1)

2-2: Test expectation correctly updated for Rspack 1.6.4 diagnostic enhancements.

Consistent with the previous file, the loader-scoped error message format now includes loader context. The extended stack trace (lines 3–10) and secondary parse error details (lines 12–19) properly reflect the enhanced diagnostic output from Rspack 1.6.4.

packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/1.snap.txt (2)

10-10: Auto-generated snapshot update consistent with Rspack 1.6.4 bump.

The hot-update bundle size decreased by 4 bytes, reflecting minor optimizations in the new Rspack version. This is expected from snapshot regeneration.

---

51-51: Comment text updated by Rspack 1.6.4 code generator.

The inline comment changed from /* ESM default export */ to /* export default */. This reflects a change in how Rspack generates comments for default exports—a non-functional cosmetic change. Based on learnings, auto-generated snapshots like this one should be regenerated by the test suite rather than manually edited, and this change is consistent with that pattern.

packages/webpack/css-extract-webpack-plugin/test/hotCases/modules/export-default/__snapshot__/rspack/2.snap.txt (2)

10-10: Auto-generated snapshot update consistent with Step 1 snapshot.

The hot-update bundle size decreased by 4 bytes, matching the optimization in 1.snap.txt. This confirms consistent snapshot regeneration across test steps with Rspack 1.6.4.

---

51-51: Comment text updated consistently with Step 1 snapshot.

The inline comment changed from /* ESM default export */ to /* export default */, consistent with the comment update in 1.snap.txt. This reflects Rspack 1.6.4's code generation behavior for default exports in CSS modules.

packages/webpack/react-refresh-webpack-plugin/test/hotCases/jsx/basic/__snapshot__/rspack/1.snap.txt (1)

9-9: ✅ Snapshot updates properly regenerated across all test cases.

Verification confirms that all 7 related Rspack snapshot files have been consistently regenerated with the simplified import comment style from Rspack v1.6.3+. No old-style /* ESM import */ comments remain, and the 4-byte size reduction is an expected consequence of the shorter comment text.

This is legitimate auto-generated snapshot output reflecting the bundler's intentional comment simplification in the Rspack version upgrade.

packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/rspack.txt (1)

1-12: Diagnostic expectation correctly updated and consistent across the PR.

The file has been properly regenerated to reflect Rspack 1.6.4's improved diagnostic format. Verification across multiple diagnostic expectation files confirms consistent application of the loader provenance pattern (e.g., from ../../../../../node_modules/<PNPM_INNER>/sass-loader/dist/cjs.js) in error messages. The standardized use of placeholders (<LINE:COLUMN>, <ROOT>, <PNPM_INNER>) and structured error output indicates systematic regeneration rather than manual editing.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[codspeed-hq]

CodSpeed Performance Report

Merging #1938 will degrade performances by 6.77%

_{Comparing colinaaa:colin/1114/rspack-1.6 (609595e) with main (6acb37b)¹}

Summary

⚡ 1 improvement
❌ 3 regressions
✅ 59 untouched
⏩ 3 skipped²

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	transform 1000 view elements	43.5 ms	46 ms	-5.4%
❌	basic-performance-large-css	11.4 ms	12 ms	-5.56%
⚡	basic-performance-nest-level-100	6.8 ms	6.1 ms	+11.7%
❌	basic-performance-small-css	6.9 ms	7.4 ms	-6.77%

Footnotes

1. No successful run was found on main (0f2da6b) during the generation of this report, so 6acb37b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[relativeci]

Web Explorer

#6238 Bundle Size — 366.97KiB (+0.02%).

609595e(current) vs 0f2da6b main#6237(baseline)

Bundle metrics   3 changes 1 regression

	Current #6238	Baseline #6237
Initial JS	146.27KiB(+0.03%)	146.22KiB
Initial CSS	32.37KiB	32.37KiB
Cache Invalidation	57.85%	0%
Chunks	8	8
Assets	8	8
Modules	221(+1.38%)	218
Duplicate Modules	16	16
Duplicate Code	3.21%	3.21%
Packages	4	4
Duplicate Packages	0	0

Bundle size by type   1 change 1 regression

	Current #6238	Baseline #6237
JS	240.8KiB (+0.02%)	240.74KiB
Other	93.8KiB	93.8KiB
CSS	32.37KiB	32.37KiB

Bundle analysis report Branch colinaaa:colin/1114/rspack-1.6 Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}