fix(web): bindtap detail should contain x, y #1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 43b634d The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📝 WalkthroughWalkthroughThis PR ensures bindtap/click events include mouse coordinates by extracting x and y into event.detail, adds a testsuite and test component verifying the behavior, updates offscreen document property collection to include x and y, and adds a changeset entry recording the patch-level fix. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used📓 Path-based instructions (1).changeset/*.md📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (8)📓 Common learnings📚 Learning: 2025-10-11T06:16:12.517ZApplied to files:
📚 Learning: 2025-08-11T05:57:18.212ZApplied to files:
📚 Learning: 2025-08-07T04:00:59.645ZApplied to files:
📚 Learning: 2025-09-12T09:43:04.847ZApplied to files:
📚 Learning: 2025-07-22T09:23:07.797ZApplied to files:
📚 Learning: 2025-09-12T09:43:04.847ZApplied to files:
📚 Learning: 2025-07-22T09:26:16.722ZApplied to files:
🧬 Code graph analysis (2)packages/web-platform/web-tests/tests/react.spec.ts (1)
packages/web-platform/web-tests/tests/react/basic-bindtap-detail/index.jsx (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PupilTong
previously approved these changes
Nov 3, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1913 will improve performances by 6.62%Comparing Summary
Benchmarks breakdown
Footnotes
|
Web Explorer#6086 Bundle Size — 366.7KiB (+0.01%).43b634d(current) vs c282f54 main#6080(baseline) Bundle metrics
|
| Current #6086 |
Baseline #6080 |
|
|---|---|---|
 Initial JS |
146.2KiB(~+0.01%) |
146.19KiB |
 Initial CSS |
32.22KiB |
32.22KiB |
 Cache Invalidation |
46.79% |
48.46% |
| Chunks |
8 |
8 |
| Assets |
8 |
8 |
| Modules |
219(-0.45%) |
220 |
| Duplicate Modules |
16 |
16 |
| Duplicate Code |
3.21% |
3.21% |
| Packages |
4 |
4 |
| Duplicate Packages |
0 |
0 |
Bundle size by type 1 change 1 regression
| Current #6086 |
Baseline #6080 |
|
|---|---|---|
| JS |
240.68KiB (+0.02%) |
240.64KiB |
| Other |
93.8KiB |
93.8KiB |
| CSS |
32.22KiB |
32.22KiB |
Bundle analysis report Branch Sherry-hue:fix/bindtap-detail Project dashboard
Generated by RelativeCI Documentation Report issue
React Example#6090 Bundle Size — 237.45KiB (0%).43b634d(current) vs c282f54 main#6084(baseline) Bundle metrics
|
| Current #6090 |
Baseline #6084 |
|
|---|---|---|
| Initial JS |
0B |
0B |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
0% |
0% |
| Chunks |
0 |
0 |
| Assets |
4 |
4 |
| Modules |
165 |
165 |
| Duplicate Modules |
67 |
67 |
| Duplicate Code |
46.77% |
46.77% |
| Packages |
2 |
2 |
| Duplicate Packages |
0 |
0 |
Bundle size by type no changes
| Current #6090 |
Baseline #6084 |
|
|---|---|---|
| IMG |
145.76KiB |
145.76KiB |
| Other |
91.69KiB |
91.69KiB |
Bundle analysis report Branch Sherry-hue:fix/bindtap-detail Project dashboard
Generated by RelativeCI Documentation Report issue
Sherry-hue
force-pushed
the
fix/bindtap-detail
branch
from
22dc385 to
43b634d
Compare
PupilTong
approved these changes
Nov 3, 2025
colinaaa
pushed a commit
that referenced
this pull request
Nov 9, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/[email protected] ### Patch Changes - During hydration, replace update with insert + remove for same-type `<list-item />` with different `item-key` so the Lynx Engine detects changes. ([#1598](#1598)) ```html Hydrate List B into List A: List A: <list> <list-item item-key="a">hello</list-item> <list-item item-key="a">world</list-item> </list> List B: <list> <list-item item-key="a1">hello</list-item> <list-item item-key="a2">world</list-item> </list> ``` Previously this case was hydrated as an update; it is now emitted as insert + remove to ensure SDK detection. - Bump `swc_core` v47. ([#1916](#1916)) - Pass sourcemap generated by rspack to swc transformer. ([#1910](#1910)) - When engineVersion is greater than or equal to 3.1, use `__SetAttribute` to set text attribute for text node instead of creating a raw text node. ([#1880](#1880)) - Add profile for list `update-list-info`. ([#1480](#1480)) - Support testing React Compiler in testing library. Enable React Compiler by setting the `experimental_enableReactCompiler` option of `createVitestConfig` to `true`. ([#1269](#1269)) ```js import { defineConfig, mergeConfig } from "vitest/config"; import { createVitestConfig } from "@lynx-js/react/testing-library/vitest-config"; const defaultConfig = await createVitestConfig({ runtimePkgName: "@lynx-js/react", experimental_enableReactCompiler: true, }); export default mergeConfig(defaultConfig, config); ``` ## @lynx-js/[email protected] ### Patch Changes - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: print out the output chunk urls ([#1921](#1921)) ## @lynx-js/[email protected] ### Patch Changes - When engineVersion is greater than or equal to 3.1, use `__SetAttribute` to set text attribute for text node instead of creating a raw text node. ([#1880](#1880)) - Add `react-compiler-runtime` to `resolve.dedupe`. ([#1269](#1269)) With this change you can setup [React Compiler](https://react.dev/learn/react-compiler) for ReactLynx by `pluginBabel`: ```js import { defineConfig } from "@lynx-js/rspeedy"; import { pluginBabel } from "@rsbuild/plugin-babel"; export default defineConfig({ plugins: [ pluginBabel({ include: /\.(?:jsx|tsx)$/, babelLoaderOptions(opts) { opts.plugins?.unshift([ "babel-plugin-react-compiler", // See https://react.dev/reference/react-compiler/configuration for config { // ReactLynx only supports target to version 17 target: "17", }, ]); }, }), ], }); ``` - Updated dependencies \[[`e7d186a`](e7d186a), [`0d7a4c3`](0d7a4c3)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - feat: add \_\_GetSourceMapRelease API for nativeApp. ([#1923](#1923)) - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - Updated dependencies \[[`fece7d0`](fece7d0), [`e1db63f`](e1db63f), [`ebc1a60`](ebc1a60)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: define x-foldview-slot-drag-ng typo. ([#1915](#1915)) - feat: 1. Added support for the list `estimated-main-axis-size-px` property; the width and height of `list-item` are no longer required. ([#1911](#1911)) 2. Fixed an issue where the list `lower-threshold-item-count` event would not trigger when using a horizontal layout under a waterfall layout. 3. Fixed an issue where calling the list `autoScroll` method in `useEffect` might not scroll. 4. Fixed an issue where the `scrolltolower` event might not be triggered in waterfall, because the lower styles was not updated in `registerEventEnableStatusChangeHandler`. - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: define x-foldview-slot-drag-ng typo. ([#1915](#1915)) ## @lynx-js/[email protected] ### Patch Changes - feat: update @lynx-js/web-elements to 0.8.10 ([#1914](#1914)) ## @lynx-js/[email protected] ### Patch Changes - fix: The `e.detail` in the `bindtap` callback needs to correctly include `x` and `y`. ([#1913](#1913)) - Updated dependencies \[[`ebc1a60`](ebc1a60)]: - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: `this` may be undefined in Card(). ([#1922](#1922)) - feat: add \_\_GetSourceMapRelease API for nativeApp. ([#1923](#1923)) - Updated dependencies \[[`fece7d0`](fece7d0), [`ebc1a60`](ebc1a60)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - Pass sourcemap generated by rspack to swc transformer. ([#1910](#1910)) - When engineVersion is greater than or equal to 3.1, use `__SetAttribute` to set text attribute for text node instead of creating a raw text node. ([#1880](#1880)) ## [email protected] ## @lynx-js/[email protected] ## [email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Tests
Chores
Checklist