feat(template-webpack-plugin): remove initialize compiler hooks#1898
Conversation
🦋 Changeset detectedLatest commit: 3baafe4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughMove entryName-to-filename generation and output handling from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1898 will degrade performances by 6.22%Comparing Summary
Benchmarks breakdown
Footnotes
|
Web Explorer#5986 Bundle Size — 364.68KiB (0%).3baafe4(current) vs 4296178 main#5970(baseline) Bundle metrics
Bundle size by type
|
| Current #5986 |
Baseline #5970 |
|
|---|---|---|
238.77KiB |
238.77KiB |
|
93.8KiB |
93.8KiB |
|
32.11KiB |
32.11KiB |
Bundle analysis report Branch luhc228:feat/remove-compiler-ini... Project dashboard
Generated by RelativeCI Documentation Report issue
React Example#5990 Bundle Size — 237.5KiB (0%).3baafe4(current) vs 4296178 main#5974(baseline) Bundle metrics
|
| Current #5990 |
Baseline #5974 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
4 |
4 |
|
165 |
165 |
|
67 |
67 |
|
46.77% |
46.77% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #5990 |
Baseline #5974 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
91.74KiB |
91.74KiB |
Bundle analysis report Branch luhc228:feat/remove-compiler-ini... Project dashboard
Generated by RelativeCI Documentation Report issue
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/rspeedy@0.11.8 ### Patch Changes - feat: support web preview in rspeedy dev ([#1891](#1891)) - print URLs with labels - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.18.2 ## @lynx-js/react-rsbuild-plugin@0.11.3 ### Patch Changes - Updated dependencies \[[`96545dd`](96545dd)]: - @lynx-js/template-webpack-plugin@0.9.1 - @lynx-js/css-extract-webpack-plugin@0.6.4 - @lynx-js/react-webpack-plugin@0.7.1 - @lynx-js/react-alias-rsbuild-plugin@0.11.3 ## @lynx-js/web-constants@0.18.2 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.18.2 ## @lynx-js/web-core@0.18.2 ### Patch Changes - feat: builtinTagTransformMap add `'input': 'x-input'` ([#1907](#1907)) - Updated dependencies \[]: - @lynx-js/web-constants@0.18.2 - @lynx-js/web-mainthread-apis@0.18.2 - @lynx-js/web-worker-rpc@0.18.2 - @lynx-js/web-worker-runtime@0.18.2 ## @lynx-js/web-core-server@0.18.2 ### Patch Changes - feat: builtinTagTransformMap add `'input': 'x-input'` ([#1907](#1907)) ## @lynx-js/web-explorer@0.0.11 ### Patch Changes - feat: builtinTagTransformMap add `'input': 'x-input'` ([#1907](#1907)) ## @lynx-js/web-mainthread-apis@0.18.2 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.18.2 - @lynx-js/web-style-transformer@0.18.2 ## @lynx-js/web-worker-runtime@0.18.2 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.18.2 - @lynx-js/web-mainthread-apis@0.18.2 - @lynx-js/web-worker-rpc@0.18.2 ## @lynx-js/template-webpack-plugin@0.9.1 ### Patch Changes - Remove `compiler.hooks.initialize` as [it's not called in child compilers](https://github.com/web-infra-dev/rspack/blob/aa4ad886b900770787ecddd625d3e24a51b6b99c/packages/rspack/src/rspack.ts#L78). ([#1898](#1898)) ## create-rspeedy@0.11.8 ## @lynx-js/react-alias-rsbuild-plugin@0.11.3 ## upgrade-rspeedy@0.11.8 ## @lynx-js/web-rsbuild-server-middleware@0.18.2 ## @lynx-js/web-style-transformer@0.18.2 ## @lynx-js/web-worker-rpc@0.18.2 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
compiler.hooks.initializewill not be called in child compilers, it is only called once in main compiler.compiler.hooks.initialize.Summary by CodeRabbit
Bug Fixes
Chores
Checklist