Skip to content

fix(tsconfig): add missing reference to web-rsbuild-server-middleware#1894

Merged
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/rspeedy-fix-build
Oct 21, 2025
Merged

fix(tsconfig): add missing reference to web-rsbuild-server-middleware#1894
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/rspeedy-fix-build

Conversation

@PupilTong
Copy link
Copy Markdown
Collaborator

@PupilTong PupilTong commented Oct 21, 2025

Summary by CodeRabbit

  • Chores
    • Updated internal build configuration to improve build dependency resolution.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@PupilTong PupilTong requested a review from colinaaa as a code owner October 21, 2025 09:49
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 21, 2025

⚠️ No Changeset found

Latest commit: e134704

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 21, 2025

📝 Walkthrough

Walkthrough

A new TypeScript project reference is added to packages/rspeedy/core/tsconfig.build.json, including the path to packages/web-platform/web-rsbuild-server-middleware/tsconfig.json. This expands composite project references for build and type-check dependency resolution.

Changes

Cohort / File(s) Change Summary
TypeScript Build Configuration
packages/rspeedy/core/tsconfig.build.json
Added new tsconfig reference path: ../../web-platform/web-rsbuild-server-middleware/tsconfig.json in composite project references

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • lynx-family/lynx-stack#1831: Directly modifies the referenced tsconfig.json in packages/web-platform/web-rsbuild-server-middleware
  • lynx-family/lynx-stack#1580: Similarly adds a new TypeScript project reference to packages/rspeedy/core/tsconfig.build.json
  • lynx-family/lynx-stack#1893: Integrates the same @lynx-js/web-rsbuild-server-middleware package into packages/rspeedy/core with tsconfig reference, package dependency, and middleware usage

Suggested reviewers

  • colinaaa
  • upupming

Poem

🐰 A rabbit hops through build-time trails,
Connecting references, leaving no details—
TypeScript links grow ever true,
Composite projects join the crew!
~hop hop

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "fix(tsconfig): add missing reference to web-rsbuild-server-middleware" is directly aligned with the main change in the changeset. The raw summary confirms that the PR adds a new tsconfig reference to web-rsbuild-server-middleware in the packages/rspeedy/core/tsconfig.build.json file, which is exactly what the title describes. The title is concise, uses clear and specific language with conventional commit formatting, and would enable a teammate reviewing the repository history to immediately understand the primary change without ambiguity.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc42e83 and e134704.

📒 Files selected for processing (1)
  • packages/rspeedy/core/tsconfig.build.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: zizmor
🔇 Additional comments (1)
packages/rspeedy/core/tsconfig.build.json (1)

26-26: The reference is correct and follows the repository's naming conventions.

The file naming is intentional and consistent with the repository structure. Webpack packages (under packages/webpack/) use tsconfig.build.json, while web-platform packages (under packages/web-platform/) use tsconfig.json. Since web-rsbuild-server-middleware is a web-platform package, referencing tsconfig.json is the correct approach. The file exists, and no circular dependencies were detected.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PupilTong PupilTong enabled auto-merge (squash) October 21, 2025 09:50
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 21, 2025

CodSpeed Performance Report

Merging #1894 will not alter performance

Comparing PupilTong:p/hw/rspeedy-fix-build (e134704) with main (fc42e83)

Summary

✅ 53 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Oct 21, 2025

Web Explorer

#5948 Bundle Size — 364.68KiB (0%).

e134704(current) vs fc42e83 main#5933(baseline)

Bundle metrics  no changes
                 Current
#5948
     Baseline
#5933
No change  Initial JS 144.63KiB 144.63KiB
No change  Initial CSS 32.11KiB 32.11KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
No change  Modules 218 218
No change  Duplicate Modules 16 16
No change  Duplicate Code 3.23% 3.23%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#5948
     Baseline
#5933
No change  JS 238.77KiB 238.77KiB
No change  Other 93.8KiB 93.8KiB
No change  CSS 32.11KiB 32.11KiB

Bundle analysis reportBranch PupilTong:p/hw/rspeedy-fix-buildProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci bot commented Oct 21, 2025

React Example

#5952 Bundle Size — 237.5KiB (0%).

e134704(current) vs fc42e83 main#5937(baseline)

Bundle metrics  no changes
                 Current
#5952
     Baseline
#5937
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 165 165
No change  Duplicate Modules 67 67
No change  Duplicate Code 46.77% 46.77%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#5952
     Baseline
#5937
No change  IMG 145.76KiB 145.76KiB
No change  Other 91.74KiB 91.74KiB

Bundle analysis reportBranch PupilTong:p/hw/rspeedy-fix-buildProject dashboard


Generated by RelativeCIDocumentationReport issue

@PupilTong PupilTong merged commit 353312e into lynx-family:main Oct 21, 2025
83 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants