fix: avoid override user defined fetch function#181
Closed
upupming wants to merge 1 commit intolynx-family:mainfrom
Closed
fix: avoid override user defined fetch function#181upupming wants to merge 1 commit intolynx-family:mainfrom
upupming wants to merge 1 commit intolynx-family:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 4cbaa81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
upupming
commented
Mar 12, 2025
packages/webpack/runtime-wrapper-webpack-plugin/src/RuntimeWrapperWebpackPlugin.ts
Outdated
Show resolved
Hide resolved
upupming
force-pushed
the
fix/fetch
branch
3 times, most recently
from
9ce38be to
0978ef3
Compare
gaoachao
previously approved these changes
Mar 18, 2025
upupming
force-pushed
the
fix/fetch
branch
2 times, most recently
from
d874ed2 to
4cbaa81
Compare
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2025
## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> Allow direct access to `requestAnimationFrame` and `cancelAnimationFrame` in background thread script. close: #181 since `fetch` is now a parameter of the runtime wrapper. <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> ## Checklist <!--- Check and mark with an "x" --> - [x] Tests updated (or not required). - [ ] Documentation updated (or not required).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist