fix(deps): update rust crate swc_core to v42 by colinaaa · Pull Request #1766 · lynx-family/lynx-stack

colinaaa · 2025-09-17T07:26:11Z

Summary by CodeRabbit

Chores
- Updated internal dependencies to latest patch versions for improved stability and compatibility.
- No changes to functionality or public APIs; behavior remains the same for end-users.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2025-09-17T07:26:15Z

⚠️ No Changeset found

Latest commit: d7ad454

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-09-17T07:26:18Z

📝 Walkthrough

Walkthrough

Dependency versions in Cargo.toml are updated: serde to 1.0.225, serde_json to 1.0.145, and swc_core to 42.0.2. No source code or public API changes are included.

Changes

Cohort / File(s)	Summary
Dependency version bumps `Cargo.toml`	Bumped `serde` 1.0.217 → 1.0.225, `serde_json` 1.0.134 → 1.0.145, `swc_core` 39.0.3 → 42.0.2; no other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

gaoachao

Poem

A hop, a skip, I tweak the crates—
Version carrots on my plates. 🥕
Serde shines, SWC too,
JSON gleams a fresher hue.
Nose twitch-check, then off I bound—
All tidy now, with nary a sound.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title accurately and concisely identifies a real change in the changeset—updating swc_core to v42—and is specific and readable; however, the manifest also bumps serde and serde_json, so the title only partially describes the full changeset rather than every dependency change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75693e4 and d7ad454.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

Cargo.toml (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: gaoachao
PR: lynx-family/lynx-stack#1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

GitHub Check: Playwright ALL_ON_UI-CSR (2/4) / check
GitHub Check: Playwright ALL_ON_UI-CSR (2/4) / check
GitHub Check: Playwright ALL_ON_UI-CSR (2/4) / check
GitHub Check: Playwright ALL_ON_UI-CSR (2/4) / check
GitHub Check: Playwright ALL_ON_UI-CSR (2/4) / check
GitHub Check: Playwright ALL_ON_UI-CSR (2/4) / check
GitHub Check: Playwright ALL_ON_UI-CSR (2/4) / check
GitHub Check: Playwright ALL_ON_UI-CSR (2/4) / check
GitHub Check: Playwright ALL_ON_UI-CSR (2/4) / check
GitHub Check: Playwright ALL_ON_UI-CSR (2/4) / check

🔇 Additional comments (3)

Cargo.toml (3)

23-23: serde_json bump looks fine.

No known feature gating changes likely to impact typical usage. Proceed.

25-25: swc_core 42.0.2 — verify WASM plugin/runtime compatibility before merging.

Quick scan found swc_core (workspace = true) with plugin-related features in the workspace; both plugin crates declare ecma_plugin_transform — you must build/test their WASM outputs against v42 and confirm Next.js/@swc/core alignment and feature flags.

Locations:

packages/react/transform/swc-plugin-reactlynx/Cargo.toml:20 — swc_core features include "ecma_plugin_transform"

packages/react/transform/Cargo.toml:22 — swc_core features (transform-related)

packages/react/transform/swc-plugin-reactlynx-compat/Cargo.toml:16 — swc_core features include "ecma_plugin_transform"

Recommended quick checks:

Build both plugin crates for wasm32 (wasi / wasm32-unknown-unknown) and run minimal transform tests.

Verify no member crates rely on removed/renamed swc_* crates or changed feature flags.

If using Next.js/@swc/core, confirm runtime/version alignment.

22-22: No action — workspace serde derive not required

Verification script returned []: no crates use #[derive(Serialize|Deserialize)] while depending on serde via the workspace, so do not apply the suggested diff.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

relativeci · 2025-09-17T07:42:07Z

React Example

#5276 Bundle Size — 237.52KiB (0%).

d7ad454(current) vs 75693e4 main#5253(baseline)

Bundle metrics no changes

	Current #5276	Baseline #5253
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`162`	`162`
Duplicate Modules	`65`	`65`
Duplicate Code	`46.71%`	`46.71%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #5276	Baseline #5253
IMG	`145.76KiB`	`145.76KiB`
Other	`91.76KiB`	`91.76KiB`

Bundle analysis report Branch colinaaa:colin/0917/crates Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-09-17T07:42:08Z

Web Explorer

#5269 Bundle Size — 365.16KiB (0%).

d7ad454(current) vs 75693e4 main#5246(baseline)

Bundle metrics

1 change

	Current #5269	Baseline #5246
Initial JS	`145.65KiB`	`145.65KiB`
Initial CSS	`31.89KiB`	`31.89KiB`
Cache Invalidation	`0%`	`16.33%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`220`(`+1.38%`)	`217`
Duplicate Modules	`16`	`16`
Duplicate Code	`3.37%`	`3.37%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #5269	Baseline #5246
JS	`239.25KiB`	`239.25KiB`
Other	`94.02KiB`	`94.02KiB`
CSS	`31.89KiB`	`31.89KiB`

Bundle analysis report Branch colinaaa:colin/0917/crates Project dashboard

^{Generated by RelativeCI Documentation Report issue}

codspeed-hq · 2025-09-17T07:44:32Z

CodSpeed Performance Report

Merging #1766 will degrade performances by 9.73%

_{Comparing colinaaa:colin/0917/crates (d7ad454) with main (75693e4)}

🎉 Hooray! `codspeed-cpp` just leveled up to 1.2.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 1 improvement
❌ 2 regressions
✅ 53 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
❌	`transform 1000 effects`	30.4 ms	32.9 ms	-7.59%
⚡	`basic-performance-nest-level-100`	6.5 ms	6 ms	+8.59%
❌	`basic-performance-small-css`	6.9 ms	7.6 ms	-9.73%

codecov · 2025-09-17T07:46:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

fix(deps): update rust crate swc_core to v42

39cf2f2

colinaaa mentioned this pull request Sep 17, 2025

SWC no longer compiles with serde 1.0.220 or above swc-project/swc#11092

Closed

fix: bump swc_config

d7ad454

colinaaa marked this pull request as ready for review September 17, 2025 08:24

colinaaa requested a review from gaoachao September 17, 2025 08:24

gaoachao approved these changes Sep 17, 2025

View reviewed changes

gaoachao merged commit 0970d5c into lynx-family:main Sep 17, 2025
113 of 118 checks passed

coderabbitai bot mentioned this pull request Jan 29, 2026

chore(rust): bump swc_core to 56.0.0 #2154

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update rust crate swc_core to v42#1766

fix(deps): update rust crate swc_core to v42#1766
gaoachao merged 2 commits intolynx-family:mainfrom
colinaaa:colin/0917/crates

colinaaa commented Sep 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 17, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

relativeci bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

relativeci bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

colinaaa commented Sep 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

relativeci bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#5276 Bundle Size — 237.52KiB (0%).

Uh oh!

relativeci bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#5269 Bundle Size — 365.16KiB (0%).

Uh oh!

codspeed-hq bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #1766 will degrade performances by 9.73%

🎉 Hooray! codspeed-cpp just leveled up to 1.2.0!

Summary

Benchmarks breakdown

Uh oh!

codecov bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

colinaaa commented Sep 17, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Sep 17, 2025 •

edited

Loading

coderabbitai bot commented Sep 17, 2025 •

edited

Loading

relativeci bot commented Sep 17, 2025 •

edited

Loading

relativeci bot commented Sep 17, 2025 •

edited

Loading

codspeed-hq bot commented Sep 17, 2025 •

edited

Loading

🎉 Hooray! `codspeed-cpp` just leveled up to 1.2.0!

codecov bot commented Sep 17, 2025 •

edited

Loading