chore: proper updates to CODEOWNERS#1749
Conversation
|
📝 WalkthroughWalkthroughUpdated CODEOWNERS to add ownership for two path patterns: packages/react/** and benchmark/react/** assigned to @hzy. No other files or logic changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CODEOWNERS file to assign proper ownership for React-related packages and benchmarks.
- Adds ownership assignment for the
packages/react/directory to@hzy - Adds ownership assignment for the
benchmark/react/directory to@hzy
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CODEOWNERS (2)
4-4: Anchor to repo root to avoid unintended matches; precedence with transform is correct.Add a leading slash so the pattern only matches
/packages/react/**. Current order keeps/packages/react/transform/**owned by @gaoachao since last match wins.Apply:
-packages/react/** @hzy +/packages/react/** @hzyPlease also confirm there are no later
packages/react/**or broaderpackages/**entries that would override this.
6-6: Prefer root-anchored path; consider if a team handle is desired.Root‑anchor to target only
/benchmark/react/**. If ownership should be by a team, replace@hzywith the team handle.Apply:
-benchmark/react/** @hzy +/benchmark/react/** @hzy
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
React Example#5211 Bundle Size — 238.9KiB (0%).e5217b8(current) vs cb84cf0 main#5210(baseline) Bundle metrics
|
| Current #5211 |
Baseline #5210 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
4 |
4 |
|
163 |
163 |
|
67 |
67 |
|
46.79% |
46.79% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #5211 |
Baseline #5210 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
93.14KiB |
93.14KiB |
Bundle analysis report Branch hzy:p/hzy/code_owners_0 Project dashboard
Generated by RelativeCI Documentation Report issue
Web Explorer#5204 Bundle Size — 364.39KiB (0%).e5217b8(current) vs cb84cf0 main#5203(baseline) Bundle metrics
Bundle size by type
|
| Current #5204 |
Baseline #5203 |
|
|---|---|---|
238.48KiB |
238.48KiB |
|
94.02KiB |
94.02KiB |
|
31.89KiB |
31.89KiB |
Bundle analysis report Branch hzy:p/hzy/code_owners_0 Project dashboard
Generated by RelativeCI Documentation Report issue
CodSpeed Performance ReportMerging #1749 will degrade performances by 13.69%Comparing Summary
Benchmarks breakdown
|
Summary by CodeRabbit
Checklist