ci(benchmark/react): disable setting GCThreshold to int_max when frozen mode

[hzy]

To compare: lynx-family/lynx@develop...hzy:lynx:p/hzy/benchx_cli

Summary by CodeRabbit

• Chores
  • Updated internal build configuration for Lynx benchx_cli; no user-facing changes.
  • Build produces the same functionality and performance; no action required for users.
  • This affects only the packaging pipeline and does not modify app features or UI.
  • Release artifacts remain compatible with previous versions.
  • Deployment process unaffected.

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).
• Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

[changeset-bot]

⚠️ No Changeset found

Latest commit: f60132b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated the PICK_COMMIT constant in the benchx_cli build script to a new commit hash, changing which commit is cherry-picked during the build. No other logic or constants were modified.

Changes

Cohort / File(s)	Summary of changes
Build script constant update packages/lynx/benchx_cli/scripts/build.mjs	Updated PICK_COMMIT from 3d75a38c2e5b422da9b32851a1bd5dfe25ca8ed6 to ce49dc44c73bb26bb6c1cc56d0ae86fa45cc254c; no other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• ci(benchmark/react): enable "LYNX_ENABLE_FROZEN_MODE=true" #1623 — Updates the same PICK_COMMIT constant in the same build script.
• ci(benchmark/react): ignore some benchmarks #1625 — Also modifies PICK_COMMIT in packages/lynx/benchx_cli/scripts/build.mjs.
• ci(benchmark/react): force LynxNormalTask and LynxHighTask runs on ui thread in frozen mode #1693 — Previously set PICK_COMMIT to 3d75a38...; this PR updates it again.

Suggested labels

framework:React

Suggested reviewers

• colinaaa
• upupming

Poem

I hop through hashes, swift and keen,
Pluck one cherry, crisp and clean.
New commit scent on autumn air—
Build scripts hum without a care.
Tip-tap paws, release in sight,
From ce49dc4 I take my bite.
(^._.^)ﾉ 🥕

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Pre-merge checks

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title states the PR disables setting GCThreshold to int_max for benchmark/react frozen mode, but the provided raw_summary shows only a change to the PICK_COMMIT hash in packages/lynx/benchx_cli/scripts/build.mjs and no edits that implement or reference GCThreshold or benchmark/react configuration, so the title is misleading relative to the actual diff. The pr_objectives describe the intended change, yet the diff does not contain the corresponding implementation. Because the title describes behavior not present in the changeset, it does not accurately summarize the main change.	Either update the title to reflect the actual change (for example, "build(benchx_cli): update PICK_COMMIT hash") or amend the branch so the intended GCThreshold change and related files, tests, and documentation are included; also update the PR description and checklist to explain the purpose of the commit hash change if that is the PR's true intent.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

[Copilot]

Pull Request Overview

This PR updates the PICK_COMMIT hash in the benchmark CLI build script, changing from an older commit to a newer one that disables setting GCThreshold to int_max when in frozen mode.

• Updates the cherry-pick commit hash to incorporate a fix related to garbage collection threshold handling in frozen mode

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ad38e6 and f60132b.

📒 Files selected for processing (1)

• packages/lynx/benchx_cli/scripts/build.mjs (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-09-12T09:43:04.810Z

Learnt from: gaoachao
PR: lynx-family/lynx-stack#1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.810Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Applied to files:

• packages/lynx/benchx_cli/scripts/build.mjs

📚 Learning: 2025-09-12T09:43:04.810Z

Learnt from: gaoachao
PR: lynx-family/lynx-stack#1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.810Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.

Applied to files:

• packages/lynx/benchx_cli/scripts/build.mjs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: build / Build (Ubuntu)
• GitHub Check: build / Build (Windows)
• GitHub Check: test-rust / Test (Ubuntu)

🔇 Additional comments (2)

packages/lynx/benchx_cli/scripts/build.mjs (2)

105-106: Cherry-pick operation correctly uses the updated commit.

The script properly fetches and cherry-picks the new commit hash. The logic for applying the patch during the benchx_cli build process remains consistent.

---

123-123: Build configuration includes frozen mode as expected.

The GN build arguments correctly include enable_frozen_mode=true, which aligns with the PR objective of modifying behavior specifically when running in frozen mode.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[relativeci]

React Example

#5195 Bundle Size — 238.9KiB (0%).

f60132b(current) vs 5ad38e6 main#5156(baseline)

Bundle metrics  no changes

	Current #5195	Baseline #5156
Initial JS	0B	0B
Initial CSS	0B	0B
Cache Invalidation	0%	0%
Chunks	0	0
Assets	4	4
Modules	163	163
Duplicate Modules	67	67
Duplicate Code	46.79%	46.79%
Packages	2	2
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #5195	Baseline #5156
IMG	145.76KiB	145.76KiB
Other	93.14KiB	93.14KiB

Bundle analysis report Branch hzy:p/hzy/bench_13 Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[relativeci]

Web Explorer

#5188 Bundle Size — 362.79KiB (0%).

f60132b(current) vs 5ad38e6 main#5149(baseline)

Bundle metrics  no changes

	Current #5188	Baseline #5149
Initial JS	145.21KiB	145.21KiB
Initial CSS	31.89KiB	31.89KiB
Cache Invalidation	0%	0%
Chunks	8	8
Assets	8	8
Modules	219	219
Duplicate Modules	16	16
Duplicate Code	3.34%	3.34%
Packages	4	4
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #5188	Baseline #5149
JS	236.88KiB	236.88KiB
Other	94.02KiB	94.02KiB
CSS	31.89KiB	31.89KiB

Bundle analysis report Branch hzy:p/hzy/bench_13 Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[codspeed-hq]

CodSpeed Performance Report

Merging #1746 will improve performances by 6.03%

_{Comparing hzy:p/hzy/bench_13 (f60132b) with main (5ad38e6)}

Summary

⚡ 1 improvement
✅ 55 untouched

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	transform 1000 effects	32.5 ms	30.6 ms	+6.03%