chore(tailwind-preset): fix typos in uiVariants.md#1727
Conversation
Signed-off-by: Guangyu Du <23237626+Dugyu@users.noreply.github.com>
|
📝 WalkthroughWalkthroughUpdates a single documentation file to correct a variant selector example, adjust singular wording, and apply minor formatting changes. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/third-party/tailwind-preset/docs/plugins/lynx-ui/uiVariants.md (2)
7-7: Clarify variant syntax: preferui-open:overui-open:*.Avoid implying a wildcard. Match the later examples by showing an actual utility.
-...instead of `[data-state="open"]`, you can write `ui-open:*`. +...instead of `[data-state="open"]`, you can use the variant `ui-open:` (e.g., `ui-open:bg-blue-500`).
25-25: Minor wording tweak for precision.“patterns” is a bit vague; “attributes” is clearer in this context.
-Use a custom mapping to align with your component state structure (e.g., `data-*` patterns): +Use a custom mapping to align with your component state structure (e.g., `data-*` attributes):
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/third-party/tailwind-preset/docs/plugins/lynx-ui/uiVariants.md(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: zizmor
🔇 Additional comments (1)
packages/third-party/tailwind-preset/docs/plugins/lynx-ui/uiVariants.md (1)
13-13: Wording LGTM.Singular “prefix” is correct here and reads clearly.
Summary by CodeRabbit
data-*patterns.Checklist