ci: fix copilot-setup-steps.yml#1701
Conversation
|
📝 WalkthroughWalkthroughAdds a Rust wasm toolchain setup to the Copilot CI workflow, adjusts the turbo build filters and removes retry/continue-on-error build logic; updates AGENTS.md to use Corepack and tweaks headings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/copilot-setup-steps.yml (2)
25-31: Enable pnpm cache via setup-nodeSince we're already using setup-node, turn on the built-in pnpm cache to speed up installs.
- - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 - with: - node-version: "24" + - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 + with: + node-version: "24" + cache: 'pnpm'
52-56: Don’t mutate the workspace in a “dependency smoke test” stepRunning
pnpm dprint fmtwill modify files; that’s unnecessary for a dependency probe and can mask issues. Use--version/--helpchecks instead.- pnpm dprint fmt - pnpm changeset --help + pnpm dprint --version + pnpm changeset --help
🧹 Nitpick comments (6)
.github/workflows/copilot-setup-steps.yml (2)
32-36: Is uv actually needed here?We install uv but don't invoke Python tooling later. If the prior failures weren’t Python-related, consider removing the uv step to save ~10–15s per run. If uv is required by a hidden step, ignore this.
Would you like me to open a follow-up PR to prune it if unused?
41-46: Prefer corepack from Node over global installNode 24 bundles Corepack. Installing a global corepack can drift from the Node-bundled version. Enable Corepack and trust packageManager from package.json.
- npm install -g corepack@latest - corepack enable + corepack enable pnpm install --frozen-lockfileAGENTS.md (4)
20-25: Corepack usage looks good; add a note about pnpm version pinningSince Corepack respects the packageManager field, clarify that pnpm is pinned there. This prevents accidental local pnpm drift.
pnpm install --frozen-lockfile + +# Note: pnpm version is pinned via "packageManager" in package.json and managed by Corepack.
258-266: Remove duplicated paragraphThe “Specify what files or directories…” paragraph appears twice.
-Specify what files or directories the instructions apply to by adding applyTo frontmatter to the Markdown files, using glob syntax. - -Specify what files or directories the instructions apply to by adding applyTo frontmatter to the Markdown files, using glob syntax. For example: +Specify what files or directories the instructions apply to by adding applyTo frontmatter to the Markdown files, using glob syntax. For example:
1-4: Rename header to reflect Copilot instructions contextIf AGENTS.md also serves as the canonical Copilot custom instructions file, consider a more explicit title to aid discovery in the repo.
-# Lynx Stack +# Lynx Stack – Copilot Coding Agent Instructions
96-106: Align docs with CI: prefer rustup target vs. CLI install noteSince CI installs the wasm32 target via setup-rust-toolchain, add a one-liner that mirrors this for local dev to reduce confusion.
rustup target add wasm32-unknown-unknown +# If using rust-toolchain.toml, `rustup show` should list `wasm32-unknown-unknown`
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/copilot-setup-steps.yml(1 hunks)AGENTS.md(3 hunks)
🧰 Additional context used
🧠 Learnings (9)
📚 Learning: 2025-08-13T11:36:12.075Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1523
File: vitest.config.ts:52-72
Timestamp: 2025-08-13T11:36:12.075Z
Learning: The lynx-stack project requires Node.js >=22 as specified in package.json engines, so Node.js compatibility fallbacks for features introduced before v22 are unnecessary.
Applied to files:
AGENTS.md
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
AGENTS.md
📚 Learning: 2025-08-20T04:56:36.011Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1566
File: package.json:53-53
Timestamp: 2025-08-20T04:56:36.011Z
Learning: In lynx-stack, Node.js v24 is the preferred/default version for development (established in PR #1557), but Node.js v22 compatibility is maintained specifically for external CI systems like rspack-ecosystem-ci. The engines.node specification uses "^22 || ^24" to support both versions while keeping v24 as the primary target.
Applied to files:
AGENTS.md
📚 Learning: 2025-08-14T12:54:51.143Z
Learnt from: upupming
PR: lynx-family/lynx-stack#1370
File: .changeset/brave-melons-add.md:1-7
Timestamp: 2025-08-14T12:54:51.143Z
Learning: In the lynx-family/lynx-stack repository, packages use 0.x.x versioning where minor version bumps indicate breaking changes (not major bumps), following pre-1.0 semantic versioning conventions.
Applied to files:
AGENTS.md
📚 Learning: 2025-08-25T09:16:24.277Z
Learnt from: CR
PR: lynx-family/lynx-stack#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-25T09:16:24.277Z
Learning: Applies to .github/*.instructions.md : When you learn new patterns or best practices for `lynx-stack`, update or create one or more `.github/*.instructions.md` files with natural language instructions
Applied to files:
AGENTS.md
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
AGENTS.md
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
AGENTS.md
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
PR: lynx-family/lynx-stack#1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
AGENTS.md
📚 Learning: 2025-08-25T09:16:24.277Z
Learnt from: CR
PR: lynx-family/lynx-stack#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-25T09:16:24.277Z
Learning: Always run a full build with `pnpm turbo build` before running any tests
Applied to files:
AGENTS.md.github/workflows/copilot-setup-steps.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: code-style-check
- GitHub Check: zizmor
- GitHub Check: copilot-setup-steps
🔇 Additional comments (2)
.github/workflows/copilot-setup-steps.yml (1)
37-41: wasm-bindgen version alignment confirmed – The CLI is pinned to 0.2.101, which matches the version in Cargo.lock; no changes needed.AGENTS.md (1)
38-40: Fix Turbo watch command (current form will fail)Turbo’s syntax is
turbo run <task> --watch. The documentedpnpm turbo watch buildis invalid.-# Development build with watching -pnpm turbo watch build +# Development build with watching +pnpm turbo run build --watch⛔ Skipped due to learnings
Learnt from: CR PR: lynx-family/lynx-stack#0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-08-25T09:16:24.277Z Learning: Always run a full build with `pnpm turbo build` before running any tests
Web Explorer#4983 Bundle Size — 367.22KiB (0%).3eb8551(current) vs 2d184be main#4977(baseline) Bundle metrics
|
| Current #4983 |
Baseline #4977 |
|
|---|---|---|
 Initial JS |
144.22KiB |
144.22KiB |
| Initial CSS |
31.84KiB |
31.84KiB |
| Cache Invalidation |
0% |
0% |
| Chunks |
8 |
8 |
| Assets |
8 |
8 |
| Modules |
218 |
218 |
| Duplicate Modules |
16 |
16 |
| Duplicate Code |
3.32% |
3.32% |
| Packages |
4 |
4 |
| Duplicate Packages |
0 |
0 |
Bundle size by type no changes
| Current #4983 |
Baseline #4977 |
|
|---|---|---|
| JS |
235.59KiB |
235.59KiB |
| Other |
99.79KiB |
99.79KiB |
| CSS |
31.84KiB |
31.84KiB |
Bundle analysis report Branch colinaaa:colin/0909/copilot Project dashboard
Generated by RelativeCI Documentation Report issue
React Example#4990 Bundle Size — 238.2KiB (0%).3eb8551(current) vs 2d184be main#4984(baseline) Bundle metrics
|
| Current #4990 |
Baseline #4984 |
|
|---|---|---|
| Initial JS |
0B |
0B |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
0% |
0% |
| Chunks |
0 |
0 |
| Assets |
4 |
4 |
| Modules |
163 |
163 |
| Duplicate Modules |
67 |
67 |
| Duplicate Code |
46.88% |
46.88% |
| Packages |
2 |
2 |
| Duplicate Packages |
0 |
0 |
Bundle size by type no changes
| Current #4990 |
Baseline #4984 |
|
|---|---|---|
| IMG |
145.76KiB |
145.76KiB |
| Other |
92.45KiB |
92.45KiB |
Bundle analysis report Branch colinaaa:colin/0909/copilot Project dashboard
Generated by RelativeCI Documentation Report issue
CodSpeed Performance ReportMerging #1701 will not alter performanceComparing Summary
|
2 participants
Fix the copilot setup steps failed. See: https://github.com/lynx-family/lynx-stack/actions/runs/17578595129/job/49929491777
Also move
.github/copilot-instructions.mdtoAGENTS.mdsince GitHub supportsAGENTS.mdnow: https://github.blog/changelog/2025-08-28-copilot-coding-agent-now-supports-agents-md-custom-instructions/Summary by CodeRabbit
New Features
Chores
Documentation
Checklist