ci(benchmark/react): disable perfetto

[hzy]

Summary by CodeRabbit

• Chores
  • Updated benchx_cli build configuration to disable tracing, streamlining the build process. Build and packaging steps remain unchanged, and there are no user-facing behavior changes in the CLI. This is an internal build setup update that should not affect functionality or workflows. No action required from users.

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).
• Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3c90b4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

packages/lynx/benchx_cli/scripts/build.mjs (1)

111-125: Include GN args and cherry-pick commit in cache key
checkBinary() currently only compares COMMIT, so changes to the cherry-picked patch or GN arguments (e.g. enable_trace) won’t invalidate the cache and the build is skipped with Perfetto still enabled. Record a composite BUILD_KEY of COMMIT, PICK_COMMIT, and GN_ARGS, write that to benchx_cli.commit, and compare against it:

--- a/packages/lynx/benchx_cli/scripts/build.mjs
+++ b/packages/lynx/benchx_cli/scripts/build.mjs
@@ top-of-file
+// include cherry-pick and GN args in cache key
+const GN_TRACE = process.env.GN_TRACE || 'none';
+const GN_ARGS = `enable_unittests=true enable_trace="${GN_TRACE}" jsengine_type="quickjs" enable_frozen_mode=true`;
+const BUILD_KEY = `${COMMIT}:${PICK_COMMIT}:${GN_ARGS}`;
@@ async function checkBinary()
-    if (exitCode === 0 && stdout.trim() === COMMIT) {
+    if (exitCode === 0 && stdout.trim() === BUILD_KEY) {
       return true;
@@ build from source
-gn gen --args='enable_unittests=true enable_trace="none" jsengine_type="quickjs" enable_frozen_mode=true' out/Default
+gn gen --args="${GN_ARGS}" out/Default
@@
-  git rev-parse HEAD > ../dist/bin/benchx_cli.commit
+  echo "${BUILD_KEY}" > ../dist/bin/benchx_cli.commit

🧹 Nitpick comments (1)

packages/lynx/benchx_cli/scripts/build.mjs (1)

115-115: Make trace selection configurable (default to none in CI).

Avoid future PRs for toggling. Drive enable_trace via env, defaulting to none in CI.

// Near top
const GN_TRACE = process.env.BENCHX_TRACE ?? (process.env.CI ? 'none' : 'perfetto');
const GN_ARGS =
  `enable_unittests=true enable_trace="${GN_TRACE}" jsengine_type="quickjs" enable_frozen_mode=true`;

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7c5da3 and 413e9c9.

📒 Files selected for processing (1)

• packages/lynx/benchx_cli/scripts/build.mjs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: build / Build (Windows)
• GitHub Check: build / Build (Ubuntu)
• GitHub Check: test-rust / Test (Ubuntu)
• GitHub Check: code-style-check
• GitHub Check: zizmor
• GitHub Check: CodeQL Analyze (actions)
• GitHub Check: CodeQL Analyze (javascript-typescript)

🔇 Additional comments (1)

packages/lynx/benchx_cli/scripts/build.mjs (1)

115-115: enable_trace="none" is valid
The config.gni at the pinned commit defines "none" as the default/disable value for enable_trace (see config.gni:21).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[relativeci]

React Example

#4915 Bundle Size — 238.26KiB (0%).

3c90b4c(current) vs 64c578b main#4907(baseline)

Bundle metrics  no changes

	Current #4915	Baseline #4907
Initial JS	0B	0B
Initial CSS	0B	0B
Cache Invalidation	0%	0%
Chunks	0	0
Assets	4	4
Modules	164	164
Duplicate Modules	68	68
Duplicate Code	46.93%	46.93%
Packages	2	2
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #4915	Baseline #4907
IMG	145.76KiB	145.76KiB
Other	92.5KiB	92.5KiB

Bundle analysis report Branch hzy:p/hzy/bench_8 Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[relativeci]

Web Explorer

#4906 Bundle Size — 367.43KiB (0%).

3c90b4c(current) vs 64c578b main#4898(baseline)

Bundle metrics  no changes

	Current #4906	Baseline #4898
Initial JS	144.23KiB	144.23KiB
Initial CSS	31.84KiB	31.84KiB
Cache Invalidation	0%	0%
Chunks	8	8
Assets	8	8
Modules	220	220
Duplicate Modules	16	16
Duplicate Code	3.32%	3.32%
Packages	4	4
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #4906	Baseline #4898
JS	235.43KiB	235.43KiB
Other	100.16KiB	100.16KiB
CSS	31.84KiB	31.84KiB

Bundle analysis report Branch hzy:p/hzy/bench_8 Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[codspeed-hq]

CodSpeed Performance Report

Merging #1673 will degrade performances by 10.69%

_{Comparing hzy:p/hzy/bench_8 (3c90b4c) with main (d7c5da3)¹}

🎉 Hooray! codspeed-cpp just leveled up to 1.2.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 41 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	002-hello-reactLynx-destroyBackground	624.7 µs	699.4 µs	-10.69%
⚡	003-hello-list__main-thread-componentAtIndex__create	5.2 ms	4.6 ms	+13.67%

Footnotes

1. No successful run was found on main (6d33bea) during the generation of this report, so d7c5da3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump").