ci: should not continue on build error

[colinaaa]

Summary by CodeRabbit

• Chores
  • Strengthened CI build enforcement: build failures now block subsequent steps. This improves reliability by preventing artifacts from being produced after a failed build, surfaces issues earlier, and provides clearer failure signals. Users can expect a more predictable release process and higher confidence in build quality, with faster feedback for contributors.

Fix an regression of #1607

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).
• Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0ac5114

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed continue-on-error from the Build step in the build-all job of .github/workflows/workflow-build.yml, making build failures stop the job and skip subsequent steps.

Changes

Cohort / File(s)	Summary
CI workflow error handling .github/workflows/workflow-build.yml	Removed continue-on-error: true from the Build step (id: build) in build-all, changing failures from non-fatal to fatal and preventing later steps (e.g., uploading turbo summary) after a failed build.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• ci: add fail-fast to matrix jobs #1603 — Also adjusts error-handling in the same workflow by adding fail-fast: false to the job strategy, interacting with failure behavior.

Suggested reviewers

• PupilTong

Poem

I nibbled the YAML, crisp and neat,
Snipped “continue-on-error” for a sterner beat.
If builds now stumble, we pause the run—
No hopping ahead till the work is done.
Thump-thump goes QA, ears up high—
A bunny of CI, chasing fails that fly. 🐇🚦

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d3989e4 and 0ac5114.

📒 Files selected for processing (1)

• .github/workflows/workflow-build.yml (0 hunks)

💤 Files with no reviewable changes (1)

• .github/workflows/workflow-build.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: build / Build (Windows)
• GitHub Check: build / Build (Ubuntu)
• GitHub Check: test-rust / Test (Ubuntu)
• GitHub Check: CodeQL Analyze (javascript-typescript)

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[relativeci]

Web Explorer

#4630 Bundle Size — 368.23KiB (0%).

0ac5114(current) vs d3989e4 main#4625(baseline)

Bundle metrics  no changes

	Current #4630	Baseline #4625
Initial JS	144.31KiB	144.31KiB
Initial CSS	31.84KiB	31.84KiB
Cache Invalidation	0%	0%
Chunks	8	8
Assets	8	8
Modules	221	221
Duplicate Modules	17	17
Duplicate Code	3.85%	3.85%
Packages	4	4
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #4630	Baseline #4625
JS	236.23KiB	236.23KiB
Other	100.16KiB	100.16KiB
CSS	31.84KiB	31.84KiB

Bundle analysis report Branch colinaaa:colin/0827/build-error Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[relativeci]

React Example

#4637 Bundle Size — 237.06KiB (0%).

0ac5114(current) vs d3989e4 main#4632(baseline)

Bundle metrics  no changes

	Current #4637	Baseline #4632
Initial JS	0B	0B
Initial CSS	0B	0B
Cache Invalidation	0%	0%
Chunks	0	0
Assets	4	4
Modules	158	158
Duplicate Modules	64	64
Duplicate Code	45.83%	45.83%
Packages	2	2
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #4637	Baseline #4632
IMG	145.76KiB	145.76KiB
Other	91.3KiB	91.3KiB

Bundle analysis report Branch colinaaa:colin/0827/build-error Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[codspeed-hq]

CodSpeed Performance Report

Merging #1613 will not alter performance

_{Comparing colinaaa:colin/0827/build-error (0ac5114) with main (d3989e4)}

Summary

✅ 10 untouched benchmarks