fix(react): missing "type" in "update-list-info" in hydrate #1392

hzy · 2025-07-31T15:10:17Z

Summary by CodeRabbit

Bug Fixes
- Resolved an issue where the "type" field was missing during the hydration process, ensuring more accurate list updates.
Tests
- Updated test cases to include the new "type" field in relevant snapshots for improved test accuracy.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2025-07-31T15:10:21Z

🦋 Changeset detected

Latest commit: 963e5b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lynx-js/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-07-31T15:10:25Z

📝 Walkthrough

Walkthrough

This change updates the hydration logic in the "@lynx-js/react" package to include a missing "type" field in list update actions. The patch modifies the hydrate implementation, updates relevant tests to reflect the new "type" property, and documents the change in a changeset file.

Changes

Cohort / File(s)	Change Summary
Hydration Logic Update `packages/react/runtime/src/hydrate.ts`	Adds the `type` property to list update actions during the hydrate process.
Test Snapshots Update `packages/react/runtime/__test__/list.test.jsx`	Updates inline test snapshots to include the new `type` property in relevant test cases.
Documentation/Meta `.changeset/hot-dragons-shout.md`	Documents the patch and summarizes the addition of the `type` field in the hydrate process.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Suggested labels

framework:React

Poem

A rabbit hopped through React code,
Hydration fixed, a cleaner road!
The "type" now joins the update crew,
Tests refreshed, as snapshots grew.
With every patch, our garden's bright—
Bugs hop away, and all feels right! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af93325 and 963e5b0.

📒 Files selected for processing (3)

.changeset/hot-dragons-shout.md (1 hunks)
packages/react/runtime/__test__/list.test.jsx (4 hunks)
packages/react/runtime/src/hydrate.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (5)

📓 Common learnings

Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.

Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.

Learnt from: PupilTong
PR: lynx-family/lynx-stack#1029
File: packages/web-platform/web-core/src/uiThread/createRenderAllOnUI.ts:95-99
Timestamp: 2025-07-16T06:28:26.463Z
Learning: In the lynx-stack codebase, CSS selectors in SSR hydration are generated by their own packages, ensuring a predictable format that makes simple string manipulation safe and preferable over regex for performance reasons.

📚 Learning: in the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end...

Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.

Applied to files:

.changeset/hot-dragons-shout.md

📚 Learning: in the lynx-family/lynx-stack repository, ci checks require changesets when files matching the patte...

Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.

Applied to files:

.changeset/hot-dragons-shout.md

📚 Learning: in the lynx-stack codebase, css selectors in ssr hydration are generated by their own packages, ensu...

Learnt from: PupilTong
PR: lynx-family/lynx-stack#1029
File: packages/web-platform/web-core/src/uiThread/createRenderAllOnUI.ts:95-99
Timestamp: 2025-07-16T06:28:26.463Z
Learning: In the lynx-stack codebase, CSS selectors in SSR hydration are generated by their own packages, ensuring a predictable format that makes simple string manipulation safe and preferable over regex for performance reasons.

Applied to files:

.changeset/hot-dragons-shout.md

📚 Learning: the component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork ...

Learnt from: colinaaa
PR: lynx-family/lynx-stack#1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.

Applied to files:

packages/react/runtime/__test__/list.test.jsx

🔇 Additional comments (6)

packages/react/runtime/src/hydrate.ts (1)

314-314: LGTM! Clean fix for missing type property.

The addition of type: b.type correctly provides the missing type information in the updateAction object, ensuring consistency with how insertAction objects are constructed elsewhere in the same function (lines 346-350).

.changeset/hot-dragons-shout.md (1)

1-5: Appropriate changeset for this bugfix.

The changeset correctly identifies this as a patch-level fix for the "@lynx-js/react" package with a clear description of the issue being resolved.

packages/react/runtime/__test__/list.test.jsx (4)

1716-1716: Test snapshots correctly updated for the new type property.

The inline snapshot updates properly reflect the addition of the "type" property in updateAction objects, ensuring tests validate the complete expected structure after the hydration fix.

2023-2023: Consistent test update for JSXSpread scenario.

The snapshot correctly includes the "type" property for the list-item JSXSpread test case, maintaining consistency with other test updates.

2080-2080: Test snapshot properly updated.

The "type" property is correctly included in the updateAction object snapshot, ensuring the test validates the complete expected behavior.

2148-2148: Final test snapshot update looks good.

The last test snapshot correctly includes the new "type" property, completing the comprehensive test coverage updates for this fix.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Pull Request Overview

This PR fixes a missing "type" property in the "update-list-info" operation during the hydration process in React runtime. The fix ensures that the type information from snapshot instances is properly included when updating list information.

Adds missing type: b.type property to the update-list-info operation in hydrate function
Updates test expectations to include the new type property in assertions
Adds changeset documentation for the patch-level fix

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
packages/react/runtime/src/hydrate.ts	Adds missing `type` property to update-list-info operation
packages/react/runtime/test/list.test.jsx	Updates test expectations to include type property in assertions
.changeset/hot-dragons-shout.md	Documents the patch-level fix for the missing type property

codspeed-hq · 2025-07-31T15:29:42Z

CodSpeed Performance Report

Merging #1392 will not alter performance

_{Comparing hzy:p/hzy/update-list-info-missing-type-in-hydrate (963e5b0) with main (af93325)}

Summary

✅ 10 untouched benchmarks

relativeci · 2025-07-31T15:35:46Z

Web Explorer

#3509 Bundle Size — 341.34KiB (0%).

963e5b0(current) vs af93325 main#3505(baseline)

Bundle metrics

1 change

	Current #3509	Baseline #3505
Initial JS	`142.12KiB`	`142.12KiB`
Initial CSS	`31.84KiB`	`31.84KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`7`	`7`
Assets	`7`	`7`
Modules	`215`(`+0.47%`)	`214`
Duplicate Modules	`17`	`17`
Duplicate Code	`4%`	`4%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #3509	Baseline #3505
JS	`226.39KiB`	`226.39KiB`
Other	`83.11KiB`	`83.11KiB`
CSS	`31.84KiB`	`31.84KiB`

Bundle analysis report Branch hzy:p/hzy/update-list-info-missi... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-07-31T15:35:50Z

React Example

#3518 Bundle Size — 235.14KiB (~+0.01%).

963e5b0(current) vs af93325 main#3514(baseline)

Bundle metrics

1 change

	Current #3518	Baseline #3514
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`38.01%`	`38%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`156`	`156`
Duplicate Modules	`63`	`63`
Duplicate Code	`45.94%`	`45.94%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #3518	Baseline #3514
IMG	`145.76KiB`	`145.76KiB`
Other	`89.38KiB` (`+0.01%`)	`89.37KiB`

Bundle analysis report Branch hzy:p/hzy/update-list-info-missi... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/[email protected] ### Minor Changes - Add support for Lynx UI plugin system with configurable options. ([#1363](#1363)) - Introduced `lynxUIPlugins` option in `createLynxPreset`, allowing userland opt-in to Lynx UI specific plugins. - Implemented `uiVariants` plugin as the first UI plugin, supporting `ui-*` variant prefixes (e.g. `ui-checked`, `ui-open`) with customizable mappings. ## @lynx-js/[email protected] ### Patch Changes - Fix crash caused by not removing event listeners during destroy. ([#1379](#1379)) - Fix missing "type" in "update-list-info" in hydrate ([#1392](#1392)) ## @lynx-js/[email protected] ### Patch Changes - Bump Rsbuild v1.4.12 with Rspack v1.4.11. ([#1326](#1326)) ## @lynx-js/[email protected] ### Patch Changes - Updated dependencies \[[`e9edca0`](e9edca0), [`6f37db2`](6f37db2)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - feat: support `__ElementFromBinary` ([#1391](#1391)) - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - feat: support `__ElementFromBinary` ([#1391](#1391)) - fix: crash on chrome<96 ([#1361](#1361)) <wasm-bindgen/wasm-bindgen#4211 (comment)> <WebAssembly/binaryen#7358> The rust toolchain enables WASM feature `reference types` by default. However this feature is not supported by chromium lower than version 96 Therefore we found a workaround for it. In this implementation we detect if browser supports `reference types` first. If user's browser supported it, we load the wasm file with `reference types` on, otherwise we load the wasm file with `reference types` off. - Updated dependencies \[[`22ca433`](22ca433), [`8645d12`](8645d12), [`143e481`](143e481)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - refactor: bundle web-core-server ([#819](#819)) ## @lynx-js/[email protected] ### Patch Changes - feat: support color style for x-textarea ([#1382](#1382)) - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - feat: support `__ElementFromBinary` ([#1391](#1391)) - fix: crash on chrome<96 ([#1361](#1361)) <wasm-bindgen/wasm-bindgen#4211 (comment)> <WebAssembly/binaryen#7358> The rust toolchain enables WASM feature `reference types` by default. However this feature is not supported by chromium lower than version 96 Therefore we found a workaround for it. In this implementation we detect if browser supports `reference types` first. If user's browser supported it, we load the wasm file with `reference types` on, otherwise we load the wasm file with `reference types` off. - Updated dependencies \[[`22ca433`](22ca433)]: - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - optimize IO for all-on-ui: make startMainThreadWorker async and defer import ([#1385](#1385)) - Updated dependencies \[[`22ca433`](22ca433), [`143e481`](143e481)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - Support Rspack v1.4.9. ([#1351](#1351)) ## @lynx-js/[email protected] ### Patch Changes - feat: support elementTemplate for web ([#1374](#1374)) ## [email protected] ## @lynx-js/[email protected] ## [email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix(react): missing "type" in "update-list-info" in hydrate

963e5b0

Copilot AI review requested due to automatic review settings July 31, 2025 15:10

Copilot AI reviewed Jul 31, 2025

View reviewed changes

coderabbitai bot added the framework:React label Jul 31, 2025

colinaaa approved these changes Jul 31, 2025

View reviewed changes

hzy enabled auto-merge (squash) July 31, 2025 15:21

hzy merged commit abfc4c5 into lynx-family:main Jul 31, 2025
40 of 41 checks passed

github-actions bot mentioned this pull request Jul 31, 2025

chore: Release 2025-08-01 13:46:47 #1364

Merged

coderabbitai bot mentioned this pull request Aug 1, 2025

fix(react): recursive hydrate in list to avoid double remove & insert when move #1401

Merged

3 tasks

coderabbitai bot mentioned this pull request Aug 8, 2025

feat: add profile for list update-list-info #1480

Merged

3 tasks

coderabbitai bot mentioned this pull request Sep 4, 2025

fix: should only recycle off-screen list-item in recursive hydration #1641

Merged

3 tasks

This was referenced Oct 28, 2025

fix: Use item-key to determine whether list-item can be reused in hyd… #1900

Closed

feat: use item-key as beforeMap key in diffArrayLepus #1598

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(react): missing "type" in "update-list-info" in hydrate #1392

fix(react): missing "type" in "update-list-info" in hydrate #1392

Uh oh!

hzy commented Jul 31, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jul 31, 2025

Uh oh!

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq bot commented Jul 31, 2025

Uh oh!

Uh oh!

relativeci bot commented Jul 31, 2025

Uh oh!

relativeci bot commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(react): missing "type" in "update-list-info" in hydrate #1392

fix(react): missing "type" in "update-list-info" in hydrate #1392

Uh oh!

Conversation

hzy commented Jul 31, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Jul 31, 2025

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

codspeed-hq bot commented Jul 31, 2025

CodSpeed Performance Report

Merging #1392 will not alter performance

Summary

Uh oh!

Uh oh!

relativeci bot commented Jul 31, 2025

Web Explorer

#3509 Bundle Size — 341.34KiB (0%).

Uh oh!

relativeci bot commented Jul 31, 2025

React Example

#3518 Bundle Size — 235.14KiB (~+0.01%).

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hzy commented Jul 31, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 31, 2025 •

edited

Loading