feat: add support for __MarkTemplateElement, __MarkPartElement, and __GetTemplateParts in all-on-ui #1275
Conversation
…_GetTemplateParts in all-on-ui mark template elements in lynx by using a lynxElementTemplateMarkerAttribute attribute mark and save part elements in lynx by using a lynxPartIdAttribute use a querySelectorAll to impl the "get parts"
WalkthroughThis change introduces three new internal APIs for template and part marking within the main thread UI context: Changes
Sequence Diagram(s)sequenceDiagram
participant Test as Test Suite
participant MTGlobal as MainThreadGlobalThis
participant Element as DOM Element
Test->>MTGlobal: __MarkTemplateElement(Element)
MTGlobal->>Element: Set 'l-template' attribute
Test->>MTGlobal: __MarkPartElement(Element, partId)
MTGlobal->>Element: Set 'l-part' attribute
Test->>MTGlobal: __GetTemplateParts(templateElement)
MTGlobal->>Element: querySelectorAll('[l-part]')
MTGlobal->>Test: Return { partId: Element }
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ERROR Cannot resolve version $@rspack/core in overrides. The direct dependencies don't have dependency "@rspack/core". 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Copilot <[email protected]> Signed-off-by: PupilTong <[email protected]>
🦋 Changeset detectedLatest commit: 2a9ea1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.changeset/odd-carrots-slide.md (1)
7-7: Fix the typo in the changeset description.The feature name contains escaped underscores that make it hard to read.
-feat: support \_\_MarkTemplateElement, \_\_MarkPartElement and \_\_GetTemplateParts for all-on-ui +feat: support __MarkTemplateElement, __MarkPartElement and __GetTemplateParts for all-on-uipackages/web-platform/web-constants/src/types/MainThreadGlobalThis.ts (1)
284-285: Fix the typo in the comment.The comment contains a spelling error that should be corrected.
- // __GetTemplateParts currently only provied by the thread-strategy = "all-on-ui" (default) + // __GetTemplateParts currently only provided by the thread-strategy = "all-on-ui" (default)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
.changeset/odd-carrots-slide.md(1 hunks)packages/web-platform/web-constants/src/constants.ts(1 hunks)packages/web-platform/web-constants/src/types/Element.ts(1 hunks)packages/web-platform/web-constants/src/types/MainThreadGlobalThis.ts(2 hunks)packages/web-platform/web-constants/src/utils/generateTemplate.ts(1 hunks)packages/web-platform/web-mainthread-apis/src/createMainThreadGlobalThis.ts(4 hunks)packages/web-platform/web-mainthread-apis/src/pureElementPAPIs.ts(1 hunks)packages/web-platform/web-tests/playwright.config.ts(1 hunks)packages/web-platform/web-tests/shell-project/mainthread-test.ts(2 hunks)packages/web-platform/web-tests/tests/main-thread-apis.test.ts(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (3)
packages/web-platform/web-tests/shell-project/mainthread-test.ts (3)
packages/web-platform/web-constants/src/types/MainThreadGlobalThis.ts (1)
MainThreadGlobalThis(283-368)packages/web-platform/offscreen-document/src/webworker/OffscreenDocument.ts (3)
OffscreenDocument(23-128)operations(17-17)_onEvent(20-20)packages/web-platform/offscreen-document/src/main/initOffscreenDocument.ts (1)
initOffscreenDocument(54-245)
packages/web-platform/web-constants/src/types/MainThreadGlobalThis.ts (1)
packages/web-platform/web-constants/src/types/Element.ts (1)
WebFiberElementImpl(51-96)
packages/web-platform/web-mainthread-apis/src/createMainThreadGlobalThis.ts (4)
packages/web-platform/web-constants/src/types/MainThreadGlobalThis.ts (3)
GetTemplatePartsPAPI(275-277)MarkTemplateElementPAPI(266-268)MarkPartElementPAPI(270-273)packages/web-platform/web-constants/src/constants.ts (3)
lynxElementTemplateMarkerAttribute(21-21)lynxUniqueIdAttribute(5-5)lynxPartIdAttribute(23-23)packages/web-platform/web-mainthread-apis/src/pureElementPAPIs.ts (1)
__GetElementUniqueID(195-201)packages/web-platform/web-constants/src/types/Element.ts (1)
WebFiberElementImpl(51-96)
🪛 GitHub Check: test-typos
packages/web-platform/web-constants/src/types/MainThreadGlobalThis.ts
[warning] 284-284:
"provied" should be "provide" or "provided" or "proved".
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build / Build (Ubuntu)
- GitHub Check: build / Build (Windows)
- GitHub Check: code-style-check
- GitHub Check: CodeQL Analyze (actions)
- GitHub Check: CodeQL Analyze (javascript-typescript)
🔇 Additional comments (17)
packages/web-platform/web-constants/src/types/Element.ts (1)
52-52: Good addition to support template part querying.The optional
querySelectorAllmethod follows standard DOM API patterns and is appropriately typed. Making it optional allows for flexible implementation across different contexts.packages/web-platform/web-mainthread-apis/src/pureElementPAPIs.ts (1)
67-67: No breaking change:__GetChildrencorrectly returns a static array as specifiedThe
GetChildrenPAPItype explicitly returnsWebFiberElementImpl[] | null, and all existing consumers (including tests) use array methods like.mapand indexing on each call rather than relying on a live HTMLCollection. This implementation aligns with the declared API and test expectations—no further action required.packages/web-platform/web-tests/playwright.config.ts (1)
23-23: Appropriate test configuration update.The inclusion of
main-thread-apisin the test pattern correctly enables the new template API tests when multi-threading or SSR is enabled.packages/web-platform/web-constants/src/constants.ts (1)
21-23: Well-named constants for template functionality.The new attribute constants follow consistent naming patterns and provide clear, descriptive names for marking template elements and parts. The values
'l-template'and'l-part'are concise and follow the existing lynx attribute naming convention.packages/web-platform/web-tests/tests/main-thread-apis.test.ts (2)
9-10: Good conditional logic for multi-threading support.The environment variable check is properly implemented and used consistently throughout the test.
1220-1272: Comprehensive test coverage for the new template APIs.The test properly exercises all three new APIs (
__MarkTemplateElement,__MarkPartElement, and__GetTemplateParts) with a complex nested structure that validates the correct behavior. The test structure effectively simulates real-world usage patterns with nested templates and parts.The conditional skip for multi-threading is appropriate since these APIs are only available in the "all-on-ui" thread strategy.
packages/web-platform/web-tests/shell-project/mainthread-test.ts (3)
19-20: Consistent environment variable usage.The
ENABLE_MULTI_THREADconstant is properly defined and used consistently throughout the file.
27-45: Well-implemented conditional initialization for multi-threading.The conditional logic properly handles both multi-threaded and single-threaded modes:
- Uses
OffscreenDocumentwith callback for multi-threading- Falls back to the standard
documentfor single-threading- Properly initializes
decodeOperationonly when neededThe type annotation change from
ElementOperation[]tounknown[]is appropriate to accommodate the different operation types.
126-135: Proper conditional DOM setup and safe method calling.The
rootDomassignment correctly chooses betweendocuandshadowRootbased on the threading mode. The callback implementation safely callscommitanddecodeOperationusing optional chaining, which prevents runtime errors when these methods are not available.packages/web-platform/web-mainthread-apis/src/createMainThreadGlobalThis.ts (5)
61-64: Proper import of new constants and types.The imports for
lynxPartIdAttribute,MarkPartElementPAPI,MarkTemplateElementPAPI, andlynxElementTemplateMarkerAttributeare correctly added to support the new template functionality.
150-152: Appropriate type extension for conditional querySelectorAll support.The
rootDomtype is correctly extended to optionally includequerySelectorAll, which enables the conditional implementation of__GetTemplateParts.
661-685: Robust conditional implementation of __GetTemplateParts.The implementation correctly:
- Checks for
querySelectorAllavailability before defining the function- Validates that the element is marked as a template
- Uses a sophisticated CSS selector to find parts within the template while excluding nested template parts
- Returns an empty object for non-template elements
- Maps part IDs to their corresponding elements
The CSS selector logic
[${lynxUniqueIdAttribute}="${templateUniqueId}"] [${lynxPartIdAttribute}]:not([${lynxUniqueIdAttribute}="${templateUniqueId}"] [${lynxElementTemplateMarkerAttribute}] [${lynxPartIdAttribute}])is complex but correct—it finds parts within the template while excluding parts that belong to nested templates.
687-698: Simple and correct implementations of marking APIs.Both
__MarkTemplateElementand__MarkPartElementare straightforward implementations that properly set the required attributes using the imported constants.
707-709: Proper integration of new APIs into the global object.The new APIs are correctly added to the
MainThreadGlobalThisobject, with__GetTemplatePartsbeing conditionally included based on availability.packages/web-platform/web-constants/src/types/MainThreadGlobalThis.ts (3)
65-65: Correct type update for GetChildrenPAPI.The return type is appropriately updated to allow
nullin addition to the array, which aligns with the implementation changes.
266-277: Well-defined types for the new template APIs.The type definitions for
MarkTemplateElementPAPI,MarkPartElementPAPI, andGetTemplatePartsPAPIare properly structured with appropriate parameter types and return types.
285-288: Correct interface updates for the new APIs.The interface properly reflects the new APIs:
__GetTemplatePartsis optional as it's only available in certain thread strategies__MarkPartElementand__MarkTemplateElementare required properties- The positioning and documentation are appropriate
packages/web-platform/web-constants/src/utils/generateTemplate.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/web-platform/web-mainthread-apis/src/createMainThreadGlobalThis.ts(3 hunks)packages/web-platform/web-mainthread-apis/src/pureElementPAPIs.ts(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/web-platform/web-mainthread-apis/src/createMainThreadGlobalThis.ts
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/web-platform/web-mainthread-apis/src/pureElementPAPIs.ts (3)
packages/web-platform/web-constants/src/types/MainThreadGlobalThis.ts (3)
GetTemplatePartsPAPI(275-277)MarkTemplateElementPAPI(266-268)MarkPartElementPAPI(270-273)packages/web-platform/web-constants/src/constants.ts (3)
lynxElementTemplateMarkerAttribute(21-21)lynxUniqueIdAttribute(5-5)lynxPartIdAttribute(23-23)packages/web-platform/web-constants/src/types/Element.ts (1)
WebFiberElementImpl(51-96)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build / Build (Windows)
- GitHub Check: code-style-check
- GitHub Check: CodeQL Analyze (actions)
- GitHub Check: zizmor
- GitHub Check: CodeQL Analyze (javascript-typescript)
🔇 Additional comments (4)
packages/web-platform/web-mainthread-apis/src/pureElementPAPIs.ts (4)
10-11: LGTM! New imports are correctly added.The imports for the new constants and types are properly structured and align with the template marking functionality being introduced.
Also applies to: 32-32, 35-36, 48-48
352-356: LGTM! Template marking function is correctly implemented.The function properly sets the template marker attribute as expected.
358-363: LGTM! Part marking function is correctly implemented.The function properly sets the part ID attribute with the provided value.
73-73: No breaking change in __GetChildren – return type is already defined as an array
TheGetChildrenPAPIsignature inpackages/web-platform/web-constants/src/types/MainThreadGlobalThis.tsspecifiesWebFiberElementImpl[] | null, and all existing consumers (including tests inweb-tests) call methods like.mapdirectly on the result. This static-array implementation aligns with the PAPI type and existing usage; no code depends on a liveHTMLCollection.
No updates are required.
CodSpeed Performance ReportMerging #1275 will not alter performanceComparing Summary
|
Web Explorer#2875 Bundle Size — 303.58KiB (+0.17%).2a9ea1c(current) vs e59138b main#2874(baseline) Bundle metrics
|
| Current #2875 |
Baseline #2874 |
|
|---|---|---|
 Initial JS |
139.97KiB(+0.08%) |
139.86KiB |
 Initial CSS |
31.88KiB |
31.88KiB |
 Cache Invalidation |
72.69% |
0% |
| Chunks |
4 |
4 |
| Assets |
5 |
5 |
| Modules |
205 |
205 |
| Duplicate Modules |
17 |
17 |
| Duplicate Code |
4.23%(+0.71%) |
4.2% |
| Packages |
3 |
3 |
| Duplicate Packages |
0 |
0 |
Bundle size by type 1 change 1 regression
| Current #2875 |
Baseline #2874 |
|
|---|---|---|
| JS |
220.81KiB (+0.24%) |
220.29KiB |
| Other |
50.89KiB |
50.89KiB |
| CSS |
31.88KiB |
31.88KiB |
Bundle analysis report Branch PupilTong:p/hw/mark_template_and... Project dashboard
Generated by RelativeCI Documentation Report issue
React Example#2884 Bundle Size — 234.12KiB (0%).2a9ea1c(current) vs e59138b main#2883(baseline) Bundle metrics
|
| Current #2884 |
Baseline #2883 |
|
|---|---|---|
| Initial JS |
0B |
0B |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
0% |
0% |
| Chunks |
0 |
0 |
| Assets |
4 |
4 |
| Modules |
153 |
153 |
| Duplicate Modules |
61 |
61 |
| Duplicate Code |
45.85% |
45.85% |
| Packages |
2 |
2 |
| Duplicate Packages |
0 |
0 |
Bundle size by type no changes
| Current #2884 |
Baseline #2883 |
|
|---|---|---|
| IMG |
145.76KiB |
145.76KiB |
| Other |
88.37KiB |
88.37KiB |
Bundle analysis report Branch PupilTong:p/hw/mark_template_and... Project dashboard
Generated by RelativeCI Documentation Report issue
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for marking template and part elements and retrieving template parts in the all-on-ui runtime.
- Introduces
__MarkTemplateElement,__MarkPartElement, and__GetTemplatePartsAPIs. - Updates runtime injection, type definitions, and constants to support new template/part handling.
- Adds tests and configuration updates for the new main-thread APIs.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-platform/web-tests/tests/main-thread-apis.test.ts | Add multi-thread flag and new test for __MarkTemplateElement and __GetTemplateParts |
| packages/web-platform/web-tests/shell-project/mainthread-test.ts | Refactor multi-thread logic for OffscreenDocument and decodeOperation |
| packages/web-platform/web-tests/playwright.config.ts | Include main-thread-apis tests in Playwright configuration |
| packages/web-platform/web-mainthread-apis/src/pureElementPAPIs.ts | Implement __GetTemplateParts, __MarkTemplateElement, __MarkPartElement; update __GetChildren |
| packages/web-platform/web-mainthread-apis/src/createMainThreadGlobalThis.ts | Conditionally inject new template/part APIs and remove stub |
| packages/web-platform/web-constants/src/utils/generateTemplate.ts | Add __GetTemplateParts, __MarkPartElement, and __MarkTemplateElement to injection |
| packages/web-platform/web-constants/src/types/MainThreadGlobalThis.ts | Define new template/part API types and mark __GetTemplateParts optional |
| packages/web-platform/web-constants/src/types/Element.ts | Add optional querySelectorAll on WebFiberElementImpl |
| packages/web-platform/web-constants/src/constants.ts | Define lynxElementTemplateMarkerAttribute and lynxPartIdAttribute constants |
| .changeset/odd-carrots-slide.md | Bump package versions for new template/part APIs |
Comments suppressed due to low confidence (2)
packages/web-platform/web-tests/tests/main-thread-apis.test.ts:1221
- [nitpick] The test name is less descriptive and uses underscores. Consider renaming it to a more human-readable description like "mark template elements and retrieve template parts" to match other test naming conventions.
'__MarkTemplate_and_Get_Parts',
packages/web-platform/web-tests/shell-project/mainthread-test.ts:27
- Using
unknown[]loses type information for operations. Revert toElementOperation[](or a more specific type) to maintain type safety.
let elementOperations: unknown[] = [];
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/[email protected] ### Patch Changes - Optimize `componentAtIndex` by a few hundreds microseconds: avoiding manipulate `__pendingListUpdates` unless SnapshotInstance tree is changed ([#1201](#1201)) - Support alog of component rendering on production for better error reporting. Enable it by using `REACT_ALOG=true rspeedy dev/build` or defining `__ALOG__` to `true` in `lynx.config.js`: ([#1164](#1164)) ```js export default defineConfig({ // ... source: { define: { __ALOG__: true, }, }, }); ``` - Make `preact/debug` work with `@lynx-js/react`. ([#1222](#1222)) - Introduce `@lynx-js/react/debug` which would include debugging warnings and error messages for common mistakes found. ([#1250](#1250)) Add the import to `@lynx-js/react/debug` at the first line of the entry: ```js import "@lynx-js/react/debug"; import { root } from "@lynx-js/react"; import { App } from "./App.jsx"; root.render(<App />); ``` - `<list-item/>` deferred now accepts an object with `unmountRecycled` property to control unmounting behavior when the item is recycled. ([#1302](#1302)) For example, you can use it like this: ```jsx <list-item defer={{ unmountRecycled: true }} item-key="1"> <WillBeUnmountIfRecycled /> </list-item> ``` Now the component will be unmounted when it is recycled, which can help with performance in certain scenarios. - Avoid some unexpected `__SetAttribute` in hydrate when `undefined` is passed as an attribute value to intrinsic elements, for example: ([#1318](#1318)) ```jsx <image async-mode={undefined} /> ``` ## @lynx-js/[email protected] ### Patch Changes - Bump Rsbuild v1.4.6 with Rspack v1.4.8. ([#1282](#1282)) ## [email protected] ### Patch Changes - Add `import '@lynx-js/react/debug'` for all templates. ([#1250](#1250)) ## @lynx-js/[email protected] ### Patch Changes - Fix "TypeError: cannot read property 'call' of undefined" error during HMR updates. ([#1304](#1304)) - Supports extractStr for large JSON ([#1230](#1230)) - Change `extractStr` to `false` when `performance.chunkSplit.strategy` is not `all-in-one`. ([#1251](#1251)) - Updated dependencies \[[`cb7feb6`](cb7feb6), [`ec7228f`](ec7228f)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - Support `@lynx-js/react/debug`. ([#1250](#1250)) ## @lynx-js/[email protected] ### Patch Changes - Support alog of component rendering on production for better error reporting. Enable it by using `REACT_ALOG=true rspeedy dev/build` or defining `__ALOG__` to `true` in `lynx.config.js`: ([#1164](#1164)) ```js export default defineConfig({ // ... source: { define: { __ALOG__: true, }, }, }); ``` - Supports `console.alog` and use different `console` object in main thread and background thread. ([#1164](#1164)) ## @lynx-js/[email protected] ### Patch Changes - feat: move SSR hydrate essential info to the ssr attribute ([#1292](#1292)) We found that in browser there is no simple tool to decode a base64 string Therefore we move the data to `ssr` attribute Also fix some ssr issues - feat: support \_\_MarkTemplateElement, \_\_MarkPartElement and \_\_GetTemplateParts for all-on-ui ([#1275](#1275)) - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - feat: support SSR for all-on-ui ([#1029](#1029)) - feat: move SSR hydrate essential info to the ssr attribute ([#1292](#1292)) We found that in browser there is no simple tool to decode a base64 string Therefore we move the data to `ssr` attribute Also fix some ssr issues - feat: support \_\_MarkTemplateElement, \_\_MarkPartElement and \_\_GetTemplateParts for all-on-ui ([#1275](#1275)) - feat: mark template elements for SSR and update part ID handling ([#1286](#1286)) - Updated dependencies \[[`cebda59`](cebda59), [`1443e46`](1443e46), [`5062128`](5062128), [`f656b7f`](f656b7f)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - feat: support SSR for all-on-ui ([#1029](#1029)) - feat: move SSR hydrate essential info to the ssr attribute ([#1292](#1292)) We found that in browser there is no simple tool to decode a base64 string Therefore we move the data to `ssr` attribute Also fix some ssr issues - feat: dump the event info on ssr stage ([#1237](#1237)) - feat: mark template elements for SSR and update part ID handling ([#1286](#1286)) ## @lynx-js/[email protected] ### Patch Changes - fix: indicator dots' bg-color on safari 26 ([#1298](#1298)) <https://bugs.webkit.org/show_bug.cgi?id=296048> The animation name should be defined in the template - fix: list may only render only one column in ReactLynx. ([#1280](#1280)) This is because `span-count` may not be specified when `list-type` is specified, resulting in layout according to `span-count="1"`. Postponing the acquisition of `span-count` until layoutListItem can solve this problem. - Updated dependencies \[[`443f3d5`](443f3d5)]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: indicator dots' bg-color on safari 26 ([#1298](#1298)) <https://bugs.webkit.org/show_bug.cgi?id=296048> The animation name should be defined in the template ## @lynx-js/[email protected] ### Patch Changes - feat: support SSR for all-on-ui ([#1029](#1029)) - feat: move SSR hydrate essential info to the ssr attribute ([#1292](#1292)) We found that in browser there is no simple tool to decode a base64 string Therefore we move the data to `ssr` attribute Also fix some ssr issues - feat: support \_\_MarkTemplateElement, \_\_MarkPartElement and \_\_GetTemplateParts for all-on-ui ([#1275](#1275)) - feat: mark template elements for SSR and update part ID handling ([#1286](#1286)) - Updated dependencies \[[`1443e46`](1443e46), [`5062128`](5062128)]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - Updated dependencies \[[`cebda59`](cebda59), [`1443e46`](1443e46), [`5062128`](5062128), [`f656b7f`](f656b7f)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - Fix the `Syntax Error: expecting ';'` error of chunk splitting ([#1279](#1279)) ## [email protected] ## @lynx-js/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 participants
mark template elements in lynx by using a lynxElementTemplateMarkerAttribute attribute
mark and save part elements in lynx by using a lynxPartIdAttribute
use a querySelectorAll to impl the "get parts"
#52
Summary by CodeRabbit
New Features
Bug Fixes
Tests