feat(performance-api): add new entry components#133
Merged
colinaaa merged 8 commits intolynx-family:mainfrom Aug 28, 2025
Merged
feat(performance-api): add new entry components#133colinaaa merged 8 commits intolynx-family:mainfrom
colinaaa merged 8 commits intolynx-family:mainfrom
Conversation
🦋 Changeset detectedLatest commit: f69068f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Add new entry components for HostPlatformTiming, LazyBundleEntry, PipelineEntry, and ReloadBundleEntry with their corresponding styles and functionality. - Remove deprecated tti_entry and pipeline_entry components. - Update @lynx-js/types dependency to version 3.3.2 and modify lynx.config.mjs to reflect new entry points. The changes introduce new performance monitoring capabilities and improve the structure of the performance API examples. The removed components were outdated and replaced with more comprehensive implementations.
Tamerlx
force-pushed
the
p/limeng.amer/host_platform_timing_t
branch
from
f6da444 to
6d03e90
Compare
colinaaa
requested changes
Aug 21, 2025
| "@lynx-js/react-rsbuild-plugin": "catalog:", | ||
| "@lynx-js/rspeedy": "catalog:", | ||
| "@lynx-js/types": "^3.3.0", | ||
| "@lynx-js/types": "^3.3.2", |
Collaborator
There was a problem hiding this comment.
We will upgrade @lynx-js/types in the repo together. As you can see in #132
Contributor
Author
There was a problem hiding this comment.
OK, after the version is upgraded, I will rebase.
| const [lazyBundleEntry, setLazyBundleEntry] = useState<string>(""); | ||
| const [entryName, setEntryName] = useState<string>("Waiting..."); | ||
|
|
||
| useMemo(() => { |
Collaborator
There was a problem hiding this comment.
I don't think we need to use useMemo now. Use useEffect instead.
- It doesn't match the React semantic. The
lynx.performance.createObservershould be an effect useEffectwill be executed before hydrate, which should be early enough.
Contributor
Author
There was a problem hiding this comment.
You are right, I'll edit it.
| const [pipelineEntry, setPipelineEntry] = useState<string>(""); | ||
| const [hostPlatformTiming, setHostPlatformTiming] = useState<string>(""); | ||
|
|
||
| useMemo(() => { |
| import { ScrollItem } from "../common/ScrollItem/index.jsx"; | ||
| import "./index.scss"; | ||
|
|
||
| export default function PipelineEntryExample(this: any) { |
Collaborator
There was a problem hiding this comment.
What does the this and any for?
| const [pipelineEntry, setPipelineEntry] = useState<string>(""); | ||
| const [entryName, setEntryName] = useState<string>("pending"); | ||
|
|
||
| useMemo(() => { |
| @@ -0,0 +1,48 @@ | |||
| import * as React from "@lynx-js/react"; | |||
Collaborator
There was a problem hiding this comment.
What does this React use for?
Suggested change
| import * as React from "@lynx-js/react"; |
| import { ScrollItem } from "../common/ScrollItem/index.jsx"; | ||
| import "./index.scss"; | ||
|
|
||
| export default function LazyBundleEntryExample(this: any) { |
| @@ -0,0 +1,41 @@ | |||
| const MyLazyBundle = lazy(() => import("./MyLazyBundle.jsx")); | |||
Collaborator
There was a problem hiding this comment.
Please put any statements after imports.
| @@ -0,0 +1,50 @@ | |||
| import * as React from "@lynx-js/react"; | |||
The change replaces useMemo with useEffect for side effects in performance observer setup since useEffect is more appropriate for this use case. Also removes unnecessary React imports and 'this' parameter from function components.
Improve code organization by grouping imports together and moving lazy component declaration after imports
…platform_timing_t
…platform_timing_t
… name remove unused useCallback and useMemo imports from LazyBundleEntry rename LoadBundleEntryExample to ReloadBundleEntryExample for consistency clean up unused types dependency in pnpm-lock.yaml
colinaaa
reviewed
Aug 28, 2025
| PipelineEntry: "./src/PipelineEntry/index.tsx", | ||
| HostPlatformTiming: "./src/HostPlatformTiming/index.tsx", | ||
| ReloadBundleEntry: "./src/ReloadBundleEntry/index.tsx", | ||
| LazyBundleEntry: "./src/LazyBundleEntry/index.tsx", |
Collaborator
There was a problem hiding this comment.
Can we use the same naming convention with other entry?
Signed-off-by: Qingyu Wang <40660121+colinaaa@users.noreply.github.com>
colinaaa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes introduce new performance monitoring capabilities and improve the structure of the performance API examples. The removed components were outdated and replaced with more comprehensive implementations.