Skip to content

Log first successful container request #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catalinii merged 5 commits into from
Dec 9, 2020
Merged

Log first successful container request #20

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f639f3
Log first successful container request
Dec 9, 2020
8180002
Log first successful container request iteration 1
Dec 9, 2020
a4e1437
Log first successful container request iteration 2
Dec 9, 2020
78e73af
Log first successful container request iteration 3
Dec 9, 2020
731162d
Log first successful container request iteration 4
Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...es/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,13 @@ private[spark] class ExecutorPodsAllocator(
kubernetesClient.pods().create(podWithAttachedContainer)
newlyCreatedExecutors(newExecutorId) = clock.getTimeMillis()
logDebug(s"Requested executor with id $newExecutorId from Kubernetes.")
try {
Copy link

@rohit-menon rohit-menon Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bill has some good recommendations here for patching code. https://github.com/lyft/lyft-hadoop#patching.

Do we want to push it to a separate function at least and maybe behind a flag too.

Copy link
Author

@catalinii catalinii Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will add a new method

val m = Class.forName("com.lyft.data.spark.AppMetrics$").getField("MODULE$").get(null)
Class.forName("com.lyft.data.spark.AppMetrics$")
.getDeclaredMethod("setFirstExecutorAllocationTime").invoke(m)
} catch {
case e: Throwable =>
}
}
}

Expand Down