Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions core/src/main/scala/org/apache/spark/util/LyftUtils.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.util

private[spark] object LyftUtils {
def callObjectMethodNoArguments(objectName: String, method: String): Boolean = {
var ok = true
try {
val m = Utils.classForName(objectName).getField("MODULE$").get(null)
Utils.classForName(objectName).getDeclaredMethod(method).invoke(m)
} catch {
case e: Throwable => ok = false
}
ok
}
}
40 changes: 40 additions & 0 deletions core/src/test/scala/org/apache/spark/util/LyftUtilsSuite.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.util

import org.apache.spark.{SparkException, SparkFunSuite}
import org.apache.spark.internal.Logging

object TestObjectLyftUtils {
var testVar = 0L
def setVal() = {
testVar = 1L
}
}

class LyftUtilsSuite extends SparkFunSuite with ResetSystemProperties with Logging {

test("callObjectMethodNoArguments") {
// Test calling the method using reflection 1
val v = LyftUtils.callObjectMethodNoArguments("org.apache.spark.util.TestObjectLyftUtils$", "setVal")
assert(v === true)
assert(TestObjectLyftUtils.testVar === 1)
assert(false ==
LyftUtils.callObjectMethodNoArguments("org.apache.spark.util.TestObjectLyftUtils$", "setVal1"))
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,11 @@ private[spark] class ExecutorPodsAllocator(
kubernetesClient.pods().create(podWithAttachedContainer)
newlyCreatedExecutors(newExecutorId) = clock.getTimeMillis()
logDebug(s"Requested executor with id $newExecutorId from Kubernetes.")


org.apache.spark.util.LyftUtils.callObjectMethodNoArguments(
"com.lyft.data.spark.AppMetrics$",
"setFirstExecutorAllocationTime")
}
}

Expand Down