Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang/go: Add TypeName.IsPointer() #66

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

rvolosatovs
Copy link
Contributor

Export TypeName.IsPointer(), which can be quite useful in various scenarios.
Extracted from #51

Copy link
Contributor

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can we rework the tests to focus on this new function (instead of just transitively through Pointer)?

@rvolosatovs
Copy link
Contributor Author

@rodaine any update on this?

Copy link
Contributor

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@rodaine rodaine merged commit c5b4c16 into lyft:master Nov 14, 2019
@rvolosatovs rvolosatovs deleted the feature/is-pointer branch November 14, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants