Gogo extension support #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
force-pushed
the
feature/gogo
branch
3 times, most recently
from
cb53cdd to
d80d7e9
Compare
rvolosatovs
force-pushed
the
feature/gogo
branch
from
edcec68 to
c0cc61b
Compare
rvolosatovs
force-pushed
the
feature/gogo
branch
2 times, most recently
from
57f2f32 to
83326d5
Compare
|
Great first pass! I wouldn't overload the |
rvolosatovs
force-pushed
the
feature/gogo
branch
2 times, most recently
from
b161231 to
511261e
Compare
This was referenced Nov 4, 2019
rvolosatovs
force-pushed
the
feature/gogo
branch
from
511261e to
242acca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is draft PR closing #50
What do you think about this approach?
I based this on top of #49 since I needed to include the gogo-related dependencies