fix: treat a fragment in an empty directory as an error#1756
fix: treat a fragment in an empty directory as an error#1756mre merged 2 commits intolycheeverse:masterfrom
Conversation
6849e20 to
7e0b8d4
Compare
|
Looks good, thanks. Let's ship it! |
|
Why is the PR adding 12 links, 8 good and 4 bad ones, but the test sees only 8 added links, 7 good and 1 bad? Also it checks only for 7 more links in the test output. Are 4 links expected to not be detected as URIs, or excluded? If so, it should be maybe made clear in the file, and the test should check for detected URLs which are excluded as well. EDIT: Ah, I guess local dir links with and without trailing slash are treated as identical, hence covered by internal cache? This applies for 3 links, so I am still missing one result, and a previously succeeding link not added here turned from success to failure it seems, probably expected. |
Yes. |
No description provided.