Skip to content

fix: treat a fragment in an empty directory as an error#1756

Merged
mre merged 2 commits intolycheeverse:masterfrom
ocavue-forks:ocavue/fragment_dir
Jul 4, 2025
Merged

fix: treat a fragment in an empty directory as an error#1756
mre merged 2 commits intolycheeverse:masterfrom
ocavue-forks:ocavue/fragment_dir

Conversation

@ocavue
Copy link
Contributor

@ocavue ocavue commented Jul 4, 2025

No description provided.

@ocavue ocavue marked this pull request as ready for review July 4, 2025 07:14
@ocavue ocavue force-pushed the ocavue/fragment_dir branch from 6849e20 to 7e0b8d4 Compare July 4, 2025 07:58
@ocavue ocavue requested a review from mre July 4, 2025 07:58
@mre
Copy link
Member

mre commented Jul 4, 2025

Looks good, thanks. Let's ship it!

@mre mre merged commit 81f2605 into lycheeverse:master Jul 4, 2025
6 checks passed
@mre mre mentioned this pull request Jul 4, 2025
@MichaIng
Copy link
Member

MichaIng commented Jul 4, 2025

Why is the PR adding 12 links, 8 good and 4 bad ones, but the test sees only 8 added links, 7 good and 1 bad? Also it checks only for 7 more links in the test output.

Are 4 links expected to not be detected as URIs, or excluded? If so, it should be maybe made clear in the file, and the test should check for detected URLs which are excluded as well.

EDIT: Ah, I guess local dir links with and without trailing slash are treated as identical, hence covered by internal cache? This applies for 3 links, so I am still missing one result, and a previously succeeding link not added here turned from success to failure it seems, probably expected.

@mre mre mentioned this pull request Jul 4, 2025
@mre
Copy link
Member

mre commented Jul 4, 2025

I guess local dir links with and without trailing slash are treated as identical, hence covered by internal cache?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants