Better specs for on_max_attempts_exceeded proc #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
added 3 commits
April 1, 2015 13:59
|
K, going to merge these, release, and push to rubygems 👍 |
slpsys
added a commit
that referenced
this pull request
Apr 1, 2015
Better specs for on_max_attempts_exceeded proc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@slpsys @dollschasingmen i added specs for this behavior but i'm honestly not sure we want to be able to return the result of some random proc (and not raise an exception) when everything fails max_attempts times?
right now the actual use cases always reraise, so it's cool, but the return statement is a little misleading then.