-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #11
Refactor #11
Conversation
|
i like verboseness |
eh? |
so did you make rubocop pass by lowering all it's standards? |
i like that it's retry_constant instead of just retry, and retry is the baseline that you have to setup w/yr own behavior |
@dtboctor no, I fixed all of the issues outside of @apurvis ah, wasn't sure which way that went |
Fixing an issue with environments, refactoring a bit, adding specs, and bumping to
1.0
, because I'm breakingretry
. It used to be a synonym for constant retry intervals, but this was non-optimal for use with environments, becausePester.aws.retry {}
(which seems straightforward) would always force constant, regardless of what you chose in the environment config. That's pretty dumb, so I'm renaming the old behaviorretry_constant
, and lettingretry
defer to your environment, which is IMO the way to go for config.@apurvis @dtboctor