Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #11

Merged
merged 6 commits into from
May 1, 2015
Merged

Refactor #11

merged 6 commits into from
May 1, 2015

Conversation

slpsys
Copy link
Contributor

@slpsys slpsys commented May 1, 2015

Fixing an issue with environments, refactoring a bit, adding specs, and bumping to 1.0, because I'm breaking retry. It used to be a synonym for constant retry intervals, but this was non-optimal for use with environments, because Pester.aws.retry {} (which seems straightforward) would always force constant, regardless of what you chose in the environment config. That's pretty dumb, so I'm renaming the old behavior retry_constant, and letting retry defer to your environment, which is IMO the way to go for config.

@apurvis @dtboctor

slpsys added a commit that referenced this pull request May 1, 2015
@slpsys slpsys merged commit ccc4087 into master May 1, 2015
@slpsys slpsys deleted the self_refactor branch May 1, 2015 21:33
@slpsys
Copy link
Contributor Author

slpsys commented May 1, 2015

rake prep / rake rubocop also now passes

@apurvis
Copy link

apurvis commented May 1, 2015

i like verboseness

@slpsys
Copy link
Contributor Author

slpsys commented May 1, 2015

eh?

@dtboctor
Copy link

dtboctor commented May 1, 2015

so did you make rubocop pass by lowering all it's standards?

@apurvis
Copy link

apurvis commented May 1, 2015

i like that it's retry_constant instead of just retry, and retry is the baseline that you have to setup w/yr own behavior

@slpsys
Copy link
Contributor Author

slpsys commented May 1, 2015

@dtboctor no, I fixed all of the issues outside of retry_action (which has specs and hasn't changed in almost two years), and lowered the thresholds to exactly retry_action's levels. that's just like..how complex it is, given the features--i'm not real convinced it'd be easy or useful to break up at this point.

@apurvis ah, wasn't sure which way that went

@slpsys slpsys restored the self_refactor branch May 1, 2015 22:10
@slpsys slpsys deleted the self_refactor branch February 25, 2018 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants