Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass non-base64 secret as raw string to jsrsasign. #3

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

tappleby
Copy link

I had trouble getting this working at first, realized that jsrsasign has some automatic encoding detection based on the secret value. See https://github.com/kjur/jsrsasign/wiki/Tutorial-for-JWT-generation#jwtio-site-interoperability for more details.

I chose raw string but UTF8 is also an option.

I had trouble getting this working at first, realized that jsrsasign has some automatic encoding detection based on the secret value. See https://github.com/kjur/jsrsasign/wiki/Tutorial-for-JWT-generation#jwtio-site-interoperability for more details.

I chose raw string but UTF8 is also an option.
Copy link

@mittsh mittsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mittsh
Copy link

mittsh commented Sep 26, 2016

@hishnash @JonathanMontane You guys know more about JWT…

@mittsh
Copy link

mittsh commented Sep 26, 2016

Thanks for the update/fix @tappleby 😄

@FlorianWendelborn
Copy link

Can this please be merged? I'm sick of having to base64encode(secret) for JWT to work. :/

@mittsh
Copy link

mittsh commented Mar 31, 2017

Oops sorry for the huge huge delay @dodekeract :(
Merging this! Thank you for the reminder. And thank you for the fix @tappleby 😄

@mittsh mittsh merged commit 4aa656c into luckymarmot:master Mar 31, 2017
@mittsh
Copy link

mittsh commented Mar 31, 2017

All merged and deployed! Please update your extensions from Paw menu > Extensions > Check for Extensions Updates … (it's also automatically triggered every 24 hours)

@FlorianWendelborn
Copy link

@mittsh Thanks. This solves one of the few major issues I had with paw. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants