Skip to content

Commit

Permalink
Merge pull request #3 from tappleby/patch-1
Browse files Browse the repository at this point in the history
Pass non-base64 secret as raw string to jsrsasign.
  • Loading branch information
mittsh authored Mar 31, 2017
2 parents 02b4e08 + fcaa757 commit 4aa656c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/JsonWebTokenDynamicValue.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class JsonWebTokenDynamicValue {

const secret = this.signatureSecretIsBase64
? {b64: jsrsasign.b64utob64(this.signatureSecret)}
: this.signatureSecret;
: {rstr: this.signatureSecret};

return jsrsasign.jws.JWS.sign(null, header, payload, secret);
}
Expand Down

1 comment on commit 4aa656c

@skyzyx
Copy link

@skyzyx skyzyx commented on 4aa656c Mar 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit broke the extension.
dynamic-jwt-bug

Please sign in to comment.