Skip install step when a package has nothing to install #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
5 tasks
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Add tests and fix CI for skipping install for pure library packages
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
approved these changes
Aug 22, 2024
Signed-off-by: Michael X. Grey <[email protected]>
luca-della-vedova
merged commit c654869
into
luca-della-vedova:luca/cargo_test_support
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing out
colcon testforcolcon-cargo, I found that we get a build error fromcolcon buildif there's a Rust package that does not contain any binary crates (i.e. it only contains a library crate).This PR avoids that problem by checking each cargo package before running
cargo installto ensure it contains at least one binary crate. If there are no binary crates in the package then we simply skip thecargo installstep to avoid the spurious error code.With this, we can successfully use
colcon buildfollowed bycolcon testto run tests for library-only cargo packages.