Programming exercises: Fix misplaced inline feedback when switching files in online code editor

[b-fein]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
• I followed the coding and design guidelines.
• I documented the TypeScript code using JSDoc style.

Motivation and Context

Hotfix for issue #7033.
Inline feedback sometimes gets placed in the wrong location when switching files. This sometimes leads to overlapping feedback over code or other feedback which makes it tutors to assess the code.

Description

Always scrolls the editor to the top when switching files. This seems to fix the calculations for the annotation placement.

A more permanent solution might be #7393.

No currently available functionality is lost by always scrolling to the top:
Right now, the editor scrolls to some position dependent on whichever file you are switching from (e.g., you were in file $A$ at the very top, switch to file $B$ and scroll down, then switch back to $A$; you are now scrolled down, too). Therefore, the location in the previous file was lost anyway. With this change at least the location you end up in is consistent.

Steps for Testing

Prerequisites:

• 1 Instructor
• 1 Programming Exercise with manual assessments that contain inline feedbacks
  • One file $A$ contains an annotation somewhere at the top of the file in line $n$.
  • Another file $B$ is long enough so that you can scroll down far enough so that only lines $l > n$ are visible.
  • Note: This probably also works when starting a new assessment and creating the necessary inline annotations as you go along.

1. Go to the tutor assessment view for the submission.
2. Go to file $A$, stay at the top.
3. Switch to file $B$, scroll down so that the topmost shown line is further down than the line which contains the annotation placed in $A$.
4. Switch back to file $A$
5. All the annotations in the file are shown correctly.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

unchanged

[chrisknedl]

Line of Code + Comment looks good. Will test tomorrow.

Edit: Tested, and inline feedback is still shown correctly after following the testing steps. Thanks for (seemingly) finally finding a fix for this long-running issue.

[valentin-boehm]

Tested, looks good

[Strohgelaender]

code