Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Inline feedback sticks to top of online editor #7033

Closed
b-fein opened this issue Aug 3, 2023 · 3 comments · Fixed by #7099
Closed

Programming exercises: Inline feedback sticks to top of online editor #7033

b-fein opened this issue Aug 3, 2023 · 3 comments · Fixed by #7099

Comments

@b-fein
Copy link
Contributor

b-fein commented Aug 3, 2023

Describe the bug

Sometimes inline feedbacks get stuck to the top of the online editor.

To Reproduce

In a programming exercise with manual assessment:

  1. As tutor/instructor assess a submission and add various inline feedbacks.
  2. When switching back to files where you added annotations before or when scrolling around within a file, sometimes some of the inline feedback items get stuck to the top of the editor as shown in the screenshot.

It might take a few minutes of adding feedbacks, changing files, and scrolling to reproduce the bug.

Expected behavior

The feedbacks are not sticky but are shown at the correct location.

Screenshots

Two inline feedbacks overlapping and stuck to the top of the editor box even when scrolling:

scroll_bug

Which version of Artemis are you seeing the problem on?

6.3.8

What browsers are you seeing the problem on?

Chrome, Microsoft Edge, Firefox

Additional context

No response

Relevant log output

No response

@b-fein
Copy link
Contributor Author

b-fein commented Oct 16, 2023

Issue existing again in 6.6.0, looks like #7099 did not fix this.

Can be reproduced:

  1. Have an inline comment in line 1 of file A.
  2. Switch to file B and scroll down.
  3. Switch back to file A.

Tested for an already saved assessment.

@b-fein b-fein reopened this Oct 16, 2023
@b-fein
Copy link
Contributor Author

b-fein commented Oct 16, 2023

cc @pal03377

@b-fein
Copy link
Contributor Author

b-fein commented Dec 5, 2023

#7396 implemented a fix that is working for the common case of file-switching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants