[bazel] add shas for remaing deps for airgapped builds #12534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
added
Priority:P1
drewmacrae
approved these changes
May 9, 2022
mcy
approved these changes
May 9, 2022
timothytrippel
force-pushed
the
add-remaining-bazel-shas
branch
2 times, most recently
from
30de62c
to
146490e
Compare
timothytrippel
commented
May 9, 2022
Comment on lines
+1144
to
1155
| # TODO(lowRISC/opentitan:#12469): this was manually converted to an | ||
| # http_archive rule. Need to figure out how to update the Cargo.toml file so | ||
| # `cargo raze` will generate a (cacheable) http_archive rule to support | ||
| # air-gapped builds. | ||
| maybe( | ||
| new_git_repository, | ||
| http_archive, | ||
| name = "raze__safe_ftdi__0_3_0", | ||
| remote = "https://github.com/cr1901/safe-ftdi", | ||
| commit = "2e6ff2b77cee8c0d7c04dcdb0dea678edbd8d56f", | ||
| url = "https://github.com/cr1901/safe-ftdi/archive/2e6ff2b77cee8c0d7c04dcdb0dea678edbd8d56f.tar.gz", | ||
| sha256 = "bdc434ac8e1b379d434eec54f0aab7d272101630876bd760730f9dd0599e806c", | ||
| strip_prefix = "safe-ftdi-2e6ff2b77cee8c0d7c04dcdb0dea678edbd8d56f", | ||
| build_file = Label("//third_party/rust/crates/remote:BUILD.safe-ftdi-0.3.0.bazel"), | ||
| init_submodules = True, | ||
| ) |
There was a problem hiding this comment.
@cfrantz, this was done primarily because this Rust crate was listed using a git URL. Is there another way to reference this repository in the Cargo.toml file such that cargo raze will produce an http_archive rule instead of a git_repository rule? i.e., is there way to reference a URL to a tarball for a Rust crate dep?
This add sha256 hashes for the only remaining dependencies in our bazel workspace without them to ensure: 1) hermetic builds, and 2) support caching external bazel repo dependencies in the repository cache, which in turn supports airgapped bazel builds. These dependencies include the `com_google_absl` and `safe-fdti` rust crate external repositories. This fixes lowRISC#11792. Signed-off-by: Timothy Trippel <[email protected]>
timothytrippel
force-pushed
the
add-remaining-bazel-shas
branch
from
146490e
to
38a41a0
Compare
|
PR dependency removed. Read for merge, when CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add sha256 hashes for the only remaining dependencies in our bazel workspace without them to ensure: 1) hermetic builds, and 2) support caching external bazel repo dependencies in the repository cache, which in turn supports airgapped bazel builds.
These dependencies include the
com_google_abslandsafe-fdtirust crate external repositories.This fixes #11792.
Note: this depends on #12526 and #12533. Only review the last commit.