[bazel/rules_rust] use forked/patched rules_rust repo
#12526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in lowRISC#12515, the upstream `rules_rust` repository attempted to download several dependencies in a manner that did not first check the repository cache before going to the network. This made supporting an airgapped build environment problematic. To fix this issue, the `rules_rust` repository was forked and patched. Please follow this link for the commit message that describes the patch in detail: lowRISC/rules_rust@be0d6ca This commit update the bazel dependencies to use our patched `rust_rules` instead of the upstream ones. Additionally, this commit updates the `prep-bazel-airgapped-builds.sh` script to pre-fetch additional dependencies to pre-populate the bazel repository cache with additional required dependencies to support airgapped builds. This fixes lowRISC#12515. Signed-off-by: Timothy Trippel <[email protected]>
timothytrippel
added
Priority:P1
This was referenced May 6, 2022
mcy
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #12515, the upstream
rules_rustrepository attemptedto download several dependencies in a manner that did not first check
the repository cache before going to the network. This made supporting
an airgapped build environment problematic. To fix this issue, the
rules_rustrepository was forked and patched. Please follow this linkfor the commit message that describes the patch in detail:
lowRISC/rules_rust@be0d6ca
This commit update the bazel dependencies to use our patched
rust_rulesinstead of the upstream ones. Additionally, this commitupdates the
prep-bazel-airgapped-builds.shscript to pre-fetchadditional dependencies to pre-populate the bazel repository cache with
additional required dependencies to support airgapped builds.
This fixes #12515.
Signed-off-by: Timothy Trippel [email protected]