avoid 1 use of keyword hackery #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How I reviewed: I entered the Test tab of the ruby-head build target, then opened the tiny built-in search window, entered the word warning, and hit the arrow icon to navigate between the case-insensitive search hits. All of them were about other things. This change works on latest Ruby. Thanks, @grosser, for a meticulous fix! |
grosser
force-pushed
the
grosser/args2
branch
from
8da6906
to
8460511
Compare
|
rebased it for a clean merge |
|
@grosser Thank you! |
olleolleolle
added a commit
to grosser/faraday
that referenced
this pull request
Dec 7, 2020
I made a bad lostisland#1211 merge. This tries to repair that.
This was referenced Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1208
#1209 has some funky errors, but this change at least seems to work on old and new ruby alike