Add missing ruby2_keywords in extra place #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lostisland#1153 support for forwarding splat parameters was added, but the
DependencyLoaderupdate was later undone in lostisland#1211. According to that last PR's comments, ruby 2.7 removed the warnings that the initial PR addressed. They did try to apply a more general fix on lostisland#1209 but that PR was never merged. However, with the release of ruby 3.2.0 and the changes onruby2_keywordsthis code no longer works, raisingArgumentErrorexceptions.This PR fixes this issue for v1. Faraday v2 changed radically, and the
DependencyLoaderclass no longer exists.