Rename UploadIO -> FilePart #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code climate failure is regarding the CompositeIO class that I copied from the multipart-post gem, with some custom tweak that Faraday needs. |
1 task
olleolleolle
approved these changes
Sep 19, 2019
iMacTia
approved these changes
Sep 19, 2019
ccutrer
added a commit
to ccutrer/restforce
that referenced
this pull request
Jun 9, 2020
also fixes renamed constant see: lostisland/faraday#1021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new alias of
::UploadIO(provided by the multipart-post gem) toFaraday::FilePart. This makes it consistent withParamPart, just added in #1017.