-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update multipart docs to mention ParamPart class #1018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear and detailed 👍
Hi @technoweenie, I see you updated the documentation. Were you expecting me to add an alias to |
@jeremy-israel Not at all! I started on the docs so I could see the new class names in action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This explains the new name for the renamed class, and also includes when ParamPart was introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things documentation update brings clarity about the current (better) names.
Thanks for approving this so much! I'll try to use Draft PRs in the future :) |
Vigorous and enthusiastic approval is the best approval! |
This updates the multipart documentation on the site. It was rewritten to include
ParamsPart
from #1017, while providing other important details and example usage.Faraday::UploadIO
andFaraday::ParamsPart
before merging