Backport #1009 #1013
Closed
Backport #1009 #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable. |
|
I changed the base above to |
Closed
|
@Iakobos thanks again. I just pushed a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This backports #1009 to v0.15.x. I'm not sure what the base branch should be since versions are just tags, so I left it as
master. I just cherry-picked 27d9c93 ontov0.15.4.Rationale
We use many third-party gems that effectively specify
faraday < 1, so this allows us to continue to use those gems without warnings on Ruby 2.7 (assuming it's included in av0.15.5release).