This fixes warnings on Ruby 2.7 #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.7 issues warnings for `Proc.new` without a block: ``` warning: Capturing the given block using Proc.new is deprecated; use `&block` instead ``` This patch converts the `Proc.new` calls in to `&block`
|
Connected with #989 |
Closed
Closed
|
This was merged in August and there's been a release since then in October, but it doesn't seem to contain these fixes. Can we get this released to the non- |
This was referenced Nov 22, 2019
zenspider
pushed a commit
to zenspider/faraday
that referenced
this pull request
Nov 22, 2019
technoweenie
pushed a commit
that referenced
this pull request
Nov 27, 2019
This was referenced Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.7 issues warnings for
Proc.newwithout a block:This patch converts the
Proc.newcalls in to&block