Move changes to main #131
Merged
Move changes to main #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng jsPsych recorder initialization, and get mime type value from jsPsych recorder when a new recorder is set up
…mment about updating mime type list
Fix video recording playback issues
🦋 Changeset detectedLatest commit: 9f9647a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* add jspsych as dependency for lookit-initjspsych * extend TrialDescription type from jsPsych to create ChsTrialDescription type and replace Timeline type * extend JsPsychPlugin to include chsData and use that type in dependent types/interfaces (trial description, timeline description, timeline array) * modify UndefinedTrialType error to return element instead of index (because of recursive search in timeline) * add new UndefinedTimelineError for other timeline array/node cases * remove nth function (used for returning timeline array index in error, no longer used) * add TestPlugin class for testing * ignore TestPlugin in test coverage * add import mapping for jspsych src files for Jest tests * recursively search the jspsych timeline for objects with a type key for processing, import the TimelineArray type from jspsych src, custom CHS types and additional error * update and add tests * invoke rollup log handler to log anything other than the circular dependencies in data package * update package-lock * extend jsPsych interface to overwrite argument types in jsPsych.run * use extended jsPsych interface to fix types in jspsych.run, add type assertions * use ChsJsPsych and ChsTimelineArray types in tests * remove unknown type assertions * mark type imports with import type * Fixed TS errors in spec file --------- Co-authored-by: CJ Green <[email protected]>
okaycj
approved these changes
Mar 3, 2025
|
Just catching up - fine to release this whenever you're ready!!! |
mekline
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves recent changes on the develop branch into main: