improve param read in velocity polygon#75
Merged
papertowel123 merged 7 commits intotransient_local_publishfrom Jul 31, 2024
Merged
improve param read in velocity polygon#75papertowel123 merged 7 commits intotransient_local_publishfrom
papertowel123 merged 7 commits intotransient_local_publishfrom
Conversation
Signed-off-by: maksymdidukh <maxym.didukh@logivations.com>
55a04a0 to
c2c182f
Compare
Signed-off-by: maksymdidukh <maxym.didukh@logivations.com>
Signed-off-by: maksymdidukh <maxym.didukh@logivations.com>
Signed-off-by: maksymdidukh <maxym.didukh@logivations.com>
969df62 to
eed24f9
Compare
jplapp
approved these changes
Jul 30, 2024
jplapp
left a comment
There was a problem hiding this comment.
I think this approach is now incompatible to the upstream approach,so we wont be able to push this. We should make it so that these velocities are optional: If they are not defined for the polygon, the "main" ones should be used instead. But let's do that as a follow-up step
papertowel123
added a commit
that referenced
this pull request
Sep 3, 2024
improve param read in velocity polygon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reason for change: added the ability to set certain parameters for each sub-polygons (for limit, slowdown and approach type of velocity polygons)
so now, for each sub-polygon we can specify the slowdown_ration parameter: