Merged
Conversation
…gation#3871) * change duration tyype from int to double * change "1" to "1.0" as default wait_duration value * modify wait_action tests * fix * change int values to double in trees * add usage of Duration::from_seconds() * fix build failing issue * delete whitespace
jplapp
approved these changes
Oct 16, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change duration type from int to double
change "1" to "1.0" as default wait_duration value
modify wait_action tests
fix
change int values to double in trees
add usage of Duration::from_seconds()
fix build failing issue
delete whitespace
Basic Info
Here is a link for a PR in ros-planning/nav2 ros-navigation#3871
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: