AMRNAV-5586: Wait BT node doesn't work with double values #49
Closed
papertowel123 wants to merge 3 commits intoironfrom
Closed
AMRNAV-5586: Wait BT node doesn't work with double values #49papertowel123 wants to merge 3 commits intoironfrom
papertowel123 wants to merge 3 commits intoironfrom
Conversation
|
@maksymdidukh can you submit a PR to Nav2 to master? If you need help doing that let me know |
Author
done ros-navigation#3871 |
|
replaced by #50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Also see this PR, as the AMRNAV-5586 and AMRNAV-5586-2 branches are the same, but have different root branches
Description of contribution in a few bullet points
wait_duration port for Wait node is an integer, so if we pass something like 1.3 or 2.42 than it will automatically cast to nearest integer value, so i changed type of this port from int to double.
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: