Skip to content

AMRNAV-5586: Wait BT node doesn't work with double values #49

Closed
papertowel123 wants to merge 3 commits intoironfrom
AMRNAV-5586-2
Closed

AMRNAV-5586: Wait BT node doesn't work with double values #49
papertowel123 wants to merge 3 commits intoironfrom
AMRNAV-5586-2

Conversation

@papertowel123
Copy link

@papertowel123 papertowel123 commented Oct 10, 2023


Basic Info

Info Please fill out this column
Ticket(s) this addresses AMRNAV-5586
Primary OS tested on (Ubuntu)
Robotic platform tested on

Also see this PR, as the AMRNAV-5586 and AMRNAV-5586-2 branches are the same, but have different root branches

Description of contribution in a few bullet points

wait_duration port for Wait node is an integer, so if we pass something like 1.3 or 2.42 than it will automatically cast to nearest integer value, so i changed type of this port from int to double.

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@papertowel123 papertowel123 changed the title change duration type from int to double AMRNAV-5586: Wait BT node doesn't work with double values Oct 11, 2023
@tonynajjar
Copy link

@maksymdidukh can you submit a PR to Nav2 to master? If you need help doing that let me know

@papertowel123
Copy link
Author

wait_duration port for Wait node is an integer, so if we pass something like 1.3 or 2.42 than it will automatically cast to nearest integer value, so i changed type of this port from int to double.

done ros-navigation#3871

@tonynajjar tonynajjar closed this Oct 19, 2023
@tonynajjar
Copy link

replaced by #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants