Skip to content

pref: Increase kubernetes config QPS and Burst #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

pref: Increase kubernetes config QPS and Burst #2808

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de870f3
pref: Increase kubernetes config QPS and Burst
May 21, 2025
d8de49f
feat: Add environment variable support for Kubernetes client QPS, Bur…
May 25, 2025
632d3a1
feat: Using `VCLUSTER_PHYSICAL_CLIENT_` prefix
Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions pkg/pro/remote.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ package pro

import (
"context"
"os"
"strconv"
"time"

"github.com/loft-sh/admin-apis/pkg/licenseapi"
"github.com/loft-sh/vcluster/pkg/config"
Expand All @@ -16,9 +19,30 @@ import (

var GetRemoteClient = func(vConfig *config.VirtualClusterConfig) (*rest.Config, string, string, *rest.Config, string, string, error) {
inClusterConfig := ctrl.GetConfigOrDie()
inClusterConfig.QPS = 40
inClusterConfig.Burst = 80
inClusterConfig.Timeout = 0

// Get QPS from environment variable or default to 40
qpsStr := os.Getenv("VCLUSTER_PHYSICAL_CLIENT_QPS")
qps, err := strconv.ParseFloat(qpsStr, 32)
if err != nil || qpsStr == "" {
qps = 40
}
inClusterConfig.QPS = float32(qps)

// Get Burst from environment variable or default to 80
burstStr := os.Getenv("VCLUSTER_PHYSICAL_CLIENT_BURST")
burst, err := strconv.Atoi(burstStr)
if err != nil || burstStr == "" {
burst = 80
}
inClusterConfig.Burst = burst

// Get Timeout from environment variable or default to 0
timeoutStr := os.Getenv("VCLUSTER_PHYSICAL_CLIENT_TIMEOUT")
timeout, err := strconv.Atoi(timeoutStr)
if err != nil || timeoutStr == "" {
timeout = 0
}
inClusterConfig.Timeout = time.Duration(timeout) * time.Second

// get current namespace
currentNamespace, err := clienthelper.CurrentNamespace()
Expand Down