pref: Increase kubernetes config QPS and Burst #2808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matskiv
reviewed
May 21, 2025
Can you provide some reasoning why this change should be made? Ideally with some numbers... |
@matskiv Please rerun the tests. |
lizardruss
reviewed
Jun 4, 2025
pkg/pro/remote.go
Outdated
| inClusterConfig.QPS = float32(qps) | ||
|
|
||
| // Get Burst from environment variable or default to 80 | ||
| burstStr := os.Getenv("K8S_CLIENT_BURST") |
There was a problem hiding this comment.
similar comment as above
Ok, I'm done, and you can check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve?
none
Please provide a short message that should be published in the vcluster release notes
Increased QPS and Burst for kubernetes config from 40 to 1000 for QPS and 80 to 2000 fo Burst.