Repository navigation
[KK] Prepare B12X Kimi KDA prefill and expose MLA partial precision - #937
Closed
voipmonitor wants to merge 2 commits into
Closed
voipmonitor wants to merge 2 commits into
voipmonitor wants to merge 2 commits into
Conversation
Expose --kda-prefill-backend b12x through prepared state-pool bindings and caller-owned scratch. Avoid recurrent-state gather/scatter. Auto selection and the state/cache contract remain unchanged. Validation: KDA implementation AST matches the qualified source revision 091cdc82ef. The source commit records seven SM120 correctness cases. No GPU test was run in this audit environment. Co-authored-by: Martin Vit <martin@voipmonitor.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Codex <noreply@openai.com>
Retain BF16 defaults and qualify both partial dtypes through capacity and graph tests. GPU qualification pending. Co-authored-by: Codex <noreply@openai.com>
|
Warning Review limit reachedNext included review available in 58 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 29, 2026
Author
|
Closing: this change is already in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Enables
--kda-prefill-backend b12xfor Kimi-K3 through prepared recurrent-state bindings and reusable caller-owned scratch. Theautodefault is unchanged. ExposesVLLM_K3_DENSE_MLA_PARTIAL_DTYPE=fp32for dense MLA split partials; BF16 remains the default and the cache dtype does not change.The KDA path consumes state-pool indices directly instead of gathering and scattering recurrent states around the prefill kernel. FP32 MLA partials avoid a BF16 intermediate rounding step and double only the partial-output scratch allocation.
Implemented. Qualified in the Kimi-K3 EXL3 TP9/DCP9 integration with Red Hat DSpark K5, BF16 activation arithmetic, FP8 KV, and a 4096-token scheduler chunk. This is not a qualification of every KDA backend or TP topology.
Dependencies and compatibility
Targets
dev/karmic-krakendirectly. The FP32 selector requires B12X #441. Selecting BF16 does not require that optional precision extension. The KDA implementation uses the prepared B12X API already present onmaster.This does not duplicate #692, which concerns stateless first-token classification. The implementation does not import FlashKDA.
Validation
tests/models/kimi_k3/test_kda.py::test_b12x_kda_prefill_matches_triton_serving_batch: GPU numerical comparison passed.The performance result qualifies the composition, not an isolated speedup from this PR. Source identities, launch settings and remaining merge dependencies are tracked in #906. No broad task-quality or long-context claim is made.
AI assistance: OpenAI Codex. Maintainer review is required.