Repository navigation
[Research] Kimi memory reuse and opt-in decode prefetch experiments - #925
Merged
lukealonso merged 13 commits intoSep 28, 2026
Merged
Conversation
Signed-off-by: Martin Vit <martin@voipmonitor.org>
Signed-off-by: Martin Vit <martin@voipmonitor.org>
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (52)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Martin Vit <martin@voipmonitor.org>
Signed-off-by: Martin Vit <martin@voipmonitor.org>
Signed-off-by: Martin Vit <martin@voipmonitor.org>
This was referenced Sep 28, 2026
…imi-memory-prefetch-performance # Conflicts: # vllm/models/kimi_k3/nvidia/model.py Signed-off-by: Martin Vit <martin@voipmonitor.org>
…imi-memory-prefetch-performance
…imi-memory-prefetch-performance
lukealonso
force-pushed
the
draft/kk-kimi-memory-prefetch-performance
branch
from
September 28, 2026 03:31
006cd27 to
e307c85
Compare
lukealonso
force-pushed
the
draft/kk-kimi-prepared-mla-performance
branch
from
September 28, 2026 03:31
b2b9aa3 to
630c214
Compare
…raft Keep dense MLA dispatch and prepared prefill in the core branch while retaining optional context projection and DCP transport here. Select custom dense transport through the B12X backend name. Pre-commit checks pass; optional performance paths remain unqualified. Signed-off-by: Martin Vit <martin@voipmonitor.org>
…e draft Retain the optional memory and overlap changes on top of the prepared MLA performance branch. Dense attention selection uses B12X for prefill and decode. Optional performance qualification remains pending. Signed-off-by: Martin Vit <martin@voipmonitor.org>
lukealonso
changed the base branch from
draft/kk-kimi-prepared-mla-performance
to
dev/karmic-kraken
September 28, 2026 04:14
lukealonso
marked this pull request as ready for review
September 28, 2026 04:14
voipmonitor
added a commit
that referenced
this pull request
Sep 29, 2026
Brings #857, #842, #909, #924 and #925 (Kimi-K3 EXL3 serving and opt-in MLA/DCP/memory options) into beta. One conflict in b12x_pcie_all_reduce._plan_key: keep beta's storage-keyed fused RMSNorm weight (MiMo fused norm sites) and canonical's singleton-stride normalization. Adds a canonical-sync release fragment for #924/#925, which carry none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Research-only Kimi memory and decode experiments: bounded vision/projector execution, activation/residual storage reuse, auxiliary projection sharding, optional aligned decode GEMMs, dense-weight L2 prefetch and split KDA projection overlap.
Depends on #924 for shared projection and collective interfaces, and #857/#842 for correctness prerequisites. Integrated into
dev/karmic-kraken; optional-path GPU and performance qualification remains incomplete and was accepted by the maintainer.Validation: 168 CPU tests passed, 9 GPU cases deselected across
test_eagle3.py,test_mm_preprocess.py,test_l2_prefetch.py,test_exl3.py,test_sequence_parallel.py, the MLA output-gate dispatch cases, and full/sliding-window cache capability merging. Relevant pre-commit hooks, including mypy, pass. Exact checkpoint-dimension validation from #857/#842 is included. The complete stack preserves the original optional implementations plus review fixes, with no circular dependency between these drafts.GPU validation and performance qualification are pending. Before integration, measure each optional feature independently against the same checkpoint, topology, shapes, graph mode and baseline; require numerical correctness, changed-input graph replay, aliasing/compile compatibility and allocation stability. Storage-donation paths still require real torch.compile and graph coverage. No speedup or serving qualification is claimed.
The existing #592 targets
dev/infernal-invocationand its older hook/API layout. This preserves the prepared Karmic implementation and memory changes extracted from #857 rather than adding another patch to that lineage. L2 prefetch and projection overlap remain opt-in.AI assistance was used for separation, review fixes and validation.