This repository was archived by the owner on Oct 6, 2026. It is now read-only.
Repository navigation
Retain Trellis route-pack programs in prepared MoE plans - #442
Merged
Merged
Conversation
Keep the compiled route pack in the materialized scratch plan so bindings do not enter Triton JIT resolution. Preserve numerical behavior. Validate 24 GPU extent, activation and capacity cases including frozen resolution and poisoned-scratch graph replay.
Contributor
|
Warning Review limit reachedNext included review available in 44 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: local-inference-lab/b12x/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Retains the compiled Trellis route-pack launch carriers when materializing a prepared fused-MoE plan. The materialized caller-owned scratch receives the same carriers produced during preparation.
Without those carriers, a different live row count can try to resolve a packing kernel after kernel resolution has been frozen for serving. This is an ownership fix; it does not change expert selection, route order, decoded weights or output arithmetic.
Implemented and qualified. Targets
masterdirectly. It is independent of the optional stable-packing algorithm in #437: both the ordinary packing path and the full-codeword decoder can use this fix.Validation
24 GPU cases passed: capacities 1/8/129, uneven source extents, SiLU/SiTU, changed live row counts under frozen resolution, carrier identity, numerical reference, poisoned scratch, and CUDA Graph replay with stable allocations.
Kimi-K3 EXL3 TP9/DCP9 with Red Hat DSpark K5 starts and reproduces the control's three 4096-token outputs and acceptance counters. The integration details are in vLLM #906.
The existing preparation-ownership PR #384 concerns callable owner discovery and collective initialization; it does not transfer this component's route-pack field. AI assistance: OpenAI Codex. Maintainer review is required.