Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MODNET model #209

Merged
merged 3 commits into from
Mar 25, 2023
Merged

Remove MODNET model #209

merged 3 commits into from
Mar 25, 2023

Conversation

royshil
Copy link
Collaborator

@royshil royshil commented Mar 24, 2023

The MODNET model is heavy in size (20Mb) and it's accuracy is low compared to the others.

we have pretty good models already, so we can cut back

closing #206

@royshil royshil requested a review from umireon March 24, 2023 03:11
@royshil royshil self-assigned this Mar 24, 2023
cmake/BuildMyOnnxruntime.cmake Outdated Show resolved Hide resolved
@royshil
Copy link
Collaborator Author

royshil commented Mar 24, 2023

@umireon i was mistaken. i accidentally checked in the Cmake changes - where i shouldnt
but i've reverted hthem now
can you check it out please?

@royshil royshil requested a review from umireon March 24, 2023 19:03
Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@royshil royshil merged commit f4fc1e3 into main Mar 25, 2023
@royshil royshil deleted the roy.remove_modnet_model branch April 27, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants