Remove MODNET model (#209)

.github/workflows/main.yml

@@ -93,16 +93,20 @@ jobs:
           if [[ '${{ secrets.MACOS_SIGNING_APPLICATION_IDENTITY }}' != '' && \
                 '${{ secrets.MACOS_SIGNING_INSTALLER_IDENTITY }}' != '' && \
                 '${{ secrets.MACOS_SIGNING_CERT }}' != '' ]] {
-            print 'haveCodesignIdent=true' >> $GITHUB_OUTPUT
+            echo 'haveCodesignIdent=true' >> "$GITHUB_OUTPUT"
+            echo "found signing information"
           } else {
-            print 'haveCodesignIdent=false' >> $GITHUB_OUTPUT
+            echo 'haveCodesignIdent=false' >> "$GITHUB_OUTPUT"
+            echo "signing information not found"
           }
 
           if [[ '${{ secrets.MACOS_NOTARIZATION_USERNAME }}' != '' && \
                 '${{ secrets.MACOS_NOTARIZATION_PASSWORD }}' != '' ]] {
-            print 'haveNotarizationUser=true' >> $GITHUB_OUTPUT
+            echo 'haveNotarizationUser=true' >> "$GITHUB_OUTPUT"
+            echo "found notarization user"
           } else {
-            print 'haveNotarizationUser=false' >> $GITHUB_OUTPUT
+            echo 'haveNotarizationUser=false' >> "$GITHUB_OUTPUT"
+            echo "notarization user not found"
           }
           print '::endgroup::'
 

README.md

@@ -34,7 +34,6 @@ GPU support:
 
 The pretrained model weights used for portrait foreground segmentation are taken from:
 - https://github.com/anilsathyan7/Portrait-Segmentation/tree/master/SINet
-- https://github.com/ZHKKKe/MODNet
 - https://github.com/PaddlePaddle/PaddleSeg/tree/release/2.7/contrib/PP-HumanSeg
 - https://github.com/PINTO0309/PINTO_model_zoo/tree/main/082_MediaPipe_Meet_Segmentation
 - https://github.com/PeterL1n/RobustVideoMatting

data/locale/en-US.ini

@@ -12,7 +12,6 @@ GPUDirectML="GPU - DirectML"
 CoreML="CoreML"
 SegmentationModel="Segmentation model"
 SINet="SINet"
-MODNet="MODNet"
 MediaPipe="MediaPipe"
 SelfieSegmentation="Selfie Segmentation"
 PPHumanSeg="PPHumanSeg"

data/locale/ja-JP.ini

@@ -12,7 +12,6 @@ GPUDirectML="GPU - DirectML"
 CoreML="CoreML"
 SegmentationModel="セグメンテーションモデル"
 SINet="SINet"
-MODNet="MODNet"
 MediaPipe="MediaPipe"
 SelfieSegmentation="Selfie Segmentation"
 PPHumanSeg="PPHumanSeg"

src/background-filter.cpp

@@ -29,15 +29,13 @@
 #include <fstream>
 
 #include "plugin-macros.generated.h"
-#include "models/ModelMODNET.h"
 #include "models/ModelSINET.h"
 #include "models/ModelMediapipe.h"
 #include "models/ModelSelfie.h"
 #include "models/ModelRVM.h"
 #include "models/ModelPPHumanSeg.h"
 
 const char *MODEL_SINET = "models/SINet_Softmax_simple.onnx";
-const char *MODEL_MODNET = "models/modnet_simple.onnx";
 const char *MODEL_MEDIAPIPE = "models/mediapipe.onnx";
 const char *MODEL_SELFIE = "models/selfie_segmentation.onnx";
 const char *MODEL_RVM = "models/rvm_mobilenetv3_fp32.onnx";
@@ -130,7 +128,6 @@ static obs_properties_t *filter_properties(void *data)
                             OBS_COMBO_TYPE_LIST, OBS_COMBO_FORMAT_STRING);
 
   obs_property_list_add_string(p_model_select, obs_module_text("SINet"), MODEL_SINET);
-  obs_property_list_add_string(p_model_select, obs_module_text("MODNet"), MODEL_MODNET);
   obs_property_list_add_string(p_model_select, obs_module_text("MediaPipe"), MODEL_MEDIAPIPE);
   obs_property_list_add_string(p_model_select, obs_module_text("Selfie Segmentation"),
                                MODEL_SELFIE);
@@ -281,9 +278,6 @@ static void filter_update(void *data, obs_data_t *settings)
     if (tf->modelSelection == MODEL_SINET) {
       tf->model.reset(new ModelSINET);
     }
-    if (tf->modelSelection == MODEL_MODNET) {
-      tf->model.reset(new ModelMODNET);
-    }
     if (tf->modelSelection == MODEL_SELFIE) {
       tf->model.reset(new ModelSelfie);
     }