chore: bump web submodule — Sheet primitive eliminated, profile boxes restored#759
Conversation
… restored Picks up two web PRs: - owletto-web#127: restores the App profile + Account profile boxes on the connection settings tab (single-row regression from #121), inlines the "Manage actions" sub-sheet, and rewrites DESIGN_GUIDELINES §8 to ban <Sheet> across the package. - owletto-web#131: migrates every install/edit Sheet to inline-only forms — ConnectionForm, CreateWatcherForm, AddFeedForm, CreateEntityForm, EntityTypePage. Drops the dual-mode `inline?` shim from each, swaps Sheet-on-row navigation in clients.tsx for routed pages with keyboard-accessible row activation, replaces the "Add connection" sheet trigger with /connectors/create navigation. nav-shell-v2's mobile drawer is the only remaining <Sheet> import. Browser-verified against a local dev instance: both profile boxes render, inline Manage actions expands in place, lobu auth browser verb shows for browser_session profiles, Cancel button works on the watcher create form, keyboard nav on clients table doesn't trigger on bubbled events from nested links.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the ChangesWeb Submodule Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Bumps
packages/webfrom5b004bf→fe8334b, picking up two merged PRs in owletto-web:DESIGN_GUIDELINES.md §8to ban<Sheet>across the package.ConnectionForm,CreateWatcherForm,AddFeedForm,CreateEntityForm,EntityTypePage. Drops the dual-modeinline?shim, swaps Sheet-over-row navigation inclients.tsxfor routed pages with keyboard-accessible row activation, replaces the "Add connection" Sheet trigger with/connectors/createnavigation.nav-shell-v2.tsx's mobile drawer is the only remaining<Sheet>import.Test plan
Browser-verified against a local dev instance prior to merging:
lobu auth browser <slug>verb renders forbrowser_sessionprofiles/clientsrow click + Enter-key navigate to client detail; nested Agent link keyboard nav not hijacked/$owner/connectors/createinstead of opening a side drawercreateWatcher=true/entity-types/newrenders inline (no Sheet overlay in DOM)nav-shell-v2.tsx) left intentionally unchanged for follow-upSummary by CodeRabbit