Skip to content

chore: bump web submodule — Sheet primitive eliminated, profile boxes restored#759

Merged
buremba merged 1 commit into
mainfrom
chore/migrate-sheets
May 15, 2026
Merged

chore: bump web submodule — Sheet primitive eliminated, profile boxes restored#759
buremba merged 1 commit into
mainfrom
chore/migrate-sheets

Conversation

@buremba
Copy link
Copy Markdown
Member

@buremba buremba commented May 15, 2026

Summary

Bumps packages/web from 5b004bffe8334b, picking up two merged PRs in owletto-web:

  • owletto-web#127: restores the App profile + Account profile boxes on the connection settings tab (regression from refactor: consolidate gateway settings flow and grant-based permissions #121 — they existed for one commit before being collapsed back to a single inline row). Also inlines the "Manage actions" sub-sheet (kills the only nested-Sheet violation) and rewrites DESIGN_GUIDELINES.md §8 to ban <Sheet> across the package.
  • owletto-web#131: migrates every install/edit Sheet to inline-only forms — ConnectionForm, CreateWatcherForm, AddFeedForm, CreateEntityForm, EntityTypePage. Drops the dual-mode inline? shim, swaps Sheet-over-row navigation in clients.tsx for routed pages with keyboard-accessible row activation, replaces the "Add connection" Sheet trigger with /connectors/create navigation. nav-shell-v2.tsx's mobile drawer is the only remaining <Sheet> import.

Test plan

Browser-verified against a local dev instance prior to merging:

  • Gmail connection settings shows two stacked profile boxes (workspace OAuth app + personal OAuth account)
  • "Manage actions" expands in-place with Cancel/Save (no nested Sheet)
  • lobu auth browser <slug> verb renders for browser_session profiles
  • /clients row click + Enter-key navigate to client detail; nested Agent link keyboard nav not hijacked
  • "Add connection" navigates to /$owner/connectors/create instead of opening a side drawer
  • Watcher create form has a Cancel button; clicking clears createWatcher=true
  • /entity-types/new renders inline (no Sheet overlay in DOM)
  • Mobile nav drawer (nav-shell-v2.tsx) left intentionally unchanged for follow-up

Summary by CodeRabbit

  • Chores
    • Updated internal package dependencies and references.

Review Change Stack

… restored

Picks up two web PRs:

- owletto-web#127: restores the App profile + Account profile boxes on
  the connection settings tab (single-row regression from #121),
  inlines the "Manage actions" sub-sheet, and rewrites
  DESIGN_GUIDELINES §8 to ban <Sheet> across the package.
- owletto-web#131: migrates every install/edit Sheet to inline-only
  forms — ConnectionForm, CreateWatcherForm, AddFeedForm,
  CreateEntityForm, EntityTypePage. Drops the dual-mode `inline?`
  shim from each, swaps Sheet-on-row navigation in clients.tsx for
  routed pages with keyboard-accessible row activation, replaces the
  "Add connection" sheet trigger with /connectors/create navigation.
  nav-shell-v2's mobile drawer is the only remaining <Sheet> import.

Browser-verified against a local dev instance: both profile boxes
render, inline Manage actions expands in place, lobu auth browser
verb shows for browser_session profiles, Cancel button works on the
watcher create form, keyboard nav on clients table doesn't trigger
on bubbled events from nested links.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d8007e25-77c9-48c0-9830-c43642d8c39e

📥 Commits

Reviewing files that changed from the base of the PR and between a5f1212 and 0676ee5.

📒 Files selected for processing (1)
  • packages/web

📝 Walkthrough

Walkthrough

This PR updates the packages/web Git submodule pointer from commit 5b004... to commit fe8334..., advancing the referenced version of the web package to a newer codebase state.

Changes

Web Submodule Update

Layer / File(s) Summary
Web submodule pointer update
packages/web
The packages/web submodule commit reference is bumped to point to a different version of the web package.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • lobu-ai/lobu#728: Both PRs only change the packages/web Git submodule pointer with no application code changes in this repo.
  • lobu-ai/lobu#741: Both PRs only bump the packages/web submodule commit pointer with no app code changes.
  • lobu-ai/lobu#729: Both PRs only update the packages/web submodule commit reference.

Poem

🐰 A hop, a skip, a version bump fine,
The web package pointer takes a new line,
From 5b004 to fe8334 it flies,
Submodule updated—let's see what's inside! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: bumping the web submodule with two key improvements (Sheet elimination and profile box restoration).
Description check ✅ Passed The description covers all required template sections: Summary explains the submodule bump and linked PRs, Test plan is comprehensive with browser verification checkmarks, and Notes include follow-ups.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/migrate-sheets

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@codex-approver codex-approver Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Codex left a 👍 reaction (no suggestions).

@buremba buremba merged commit bbf1088 into main May 15, 2026
29 of 30 checks passed
@buremba buremba deleted the chore/migrate-sheets branch May 15, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants