chore: bump web — connector page cleanup + nav state correctness (#132)#760
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates the ChangesWeb submodule pointer update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/web`:
- Line 1: The pipeline is failing because the submodule pointer references
commit 00c816a4dd2bf12099d80f8f49a72a21094d07a9 which is not reachable from
owletto-web main; to fix, merge the changes from lobu-ai/owletto-web#132 into
the owletto-web main branch (or rebase that PR onto main), then update the
submodule reference in this repository to point at the resulting main branch
commit (replace the pinned commit with the new main commit hash) and push the
updated submodule pointer so FluxCD can read charts from owletto-web/main.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
buremba
force-pushed
the
chore/bump-web-connector-cleanup-and-nav
branch
2 times, most recently
from
831b495 to
6104bd1
Compare
…tness (#132) * Drop Devices/Connections h2 section headers on /$owner/connectors. * Drop the inline "Add connection / Configure" h1 in the install/edit form. * New connectionLabel(c) helper used by the connector sidebar row and the connection detail page title; replaces the awkward "Connection #${id}" fallback. * Drop NavShellV2's last-URL-per-pill cache — it picked up the bare org root and OrgRootRedirect bounced the Memory pill back to /connectors. * HomeSectionV2 + EventsStatsStrip read their org from orgContext.organizationId (URL) instead of activeOrg.id (session), so the Memory sidebar can't surface another org's data when the URL and session diverge.
buremba
force-pushed
the
chore/bump-web-connector-cleanup-and-nav
branch
from
6104bd1 to
1c00f3a
Compare
![codex-approver[bot]](https://avatars.githubusercontent.com/u/255265539?s=60&v=4){kind=small}
Member
Author
|
pi review summary Verdict: safe to admin-merge.
Merging with admin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
packages/websubmodule to pick up lobu-ai/owletto-web#132:/$owner/connectors.connectionLabel(c)helper —display_name→\${connector} · \${auth_profile_name}(or slug) → bare\${connector}. Replaces the awkwardConnection #\${id}fallback in the sidebar row and the connection detail page title.NavShellV2's per-pill last-URL cache. It picked up the bare org root on first paint, andOrgRootRedirectbounced the Memory pill back to/connectors. Pills now always go to their section landing.HomeSectionV2+EventsStatsStripderive their org fromorgContext.organizationId(URL) instead ofactiveOrg.id(session). Fixes the case where the Memory sidebar surfaced the session org's connections under a different URL org's page.Test plan
bun run buildclean in the submoduleSummary by CodeRabbit