fix(web): keep notifications visible in ⌘K while typing#712
Conversation
📝 WalkthroughWalkthroughThis PR updates the ChangesSubmodule Version Bump
Possibly related PRs
Suggested reviewers
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/web`:
- Line 1: The packages/web submodule is pinned to a nonexistent commit
(fc1baf7ccf5219dccfac1ac2cb6e491fabfd84f4) in the owletto-web repo; update the
submodule reference so packages/web points to a real commit on owletto-web/main
by checking out owletto-web/main, choosing a valid commit (or the latest tip),
and updating the submodule pointer (replace the bad hash in the submodule
reference for packages/web and commit that change); ensure the new commit hash
replaces fc1baf7ccf5219dccfac1ac2cb6e491fabfd84f4 and verify git submodule
status shows the referenced commit exists on owletto-web/main.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| @@ -1 +1 @@ | |||
| Subproject commit e222de861a0c16887a9167c47f0ecfca5c5f2df6 | |||
| Subproject commit fc1baf7ccf5219dccfac1ac2cb6e491fabfd84f4 | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check if the submodule commit exists and is reachable from main
cd packages/web
# Check if the commit exists
if git cat-file -e fc1baf7ccf5219dccfac1ac2cb6e491fabfd84f4 2>/dev/null; then
echo "✓ Commit fc1baf7 exists in the submodule"
# Check if it's reachable from main
git fetch origin main
if git merge-base --is-ancestor fc1baf7ccf5219dccfac1ac2cb6e491fabfd84f4 origin/main; then
echo "✓ Commit fc1baf7 is reachable from origin/main"
else
echo "✗ Commit fc1baf7 is NOT reachable from origin/main"
echo "Current branch containing this commit:"
git branch -r --contains fc1baf7ccf5219dccfac1ac2cb6e491fabfd84f4
fi
else
echo "✗ Commit fc1baf7 does not exist in the submodule"
fiRepository: lobu-ai/lobu
Length of output: 105
Submodule commit does not exist in packages/web.
The commit fc1baf7ccf5219dccfac1ac2cb6e491fabfd84f4 does not exist in the owletto-web submodule repository. This will prevent checkout and break the submodule reference for anyone using this code.
Verify that the correct submodule commit hash has been pinned, or update packages/web to reference an existing commit that is available in the owletto-web/main branch.
🧰 Tools
🪛 GitHub Actions: Submodule Drift / check-drift
[error] 1-1: Pinned SHA is not reachable from owletto-web/main. Error: "Pinned SHA $PINNED is not reachable from owletto-web/main." (step: git -C packages/web merge-base --is-ancestor "$PINNED" origin/main)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/web` at line 1, The packages/web submodule is pinned to a
nonexistent commit (fc1baf7ccf5219dccfac1ac2cb6e491fabfd84f4) in the owletto-web
repo; update the submodule reference so packages/web points to a real commit on
owletto-web/main by checking out owletto-web/main, choosing a valid commit (or
the latest tip), and updating the submodule pointer (replace the bad hash in the
submodule reference for packages/web and commit that change); ensure the new
commit hash replaces fc1baf7ccf5219dccfac1ac2cb6e491fabfd84f4 and verify git
submodule status shows the referenced commit exists on owletto-web/main.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Superseded by #714, which bumped |
2 participants
Summary
search === '', and each item'svaluewasnotification-<uuid>— so cmdk's fuzzy filter never matched user text and the group vanished as soon as you typed anything (including 'noti')packages/websubmoduleSubmodule PR: lobu-ai/owletto-web@fc1baf7
Test plan
Summary by CodeRabbit
No user-visible changes in this release.