feat(web): fold notifications into ⌘K, drop /inbox page (#703 submodule)#709
Conversation
📝 WalkthroughWalkthroughThe ChangesSubmodule Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/web`:
- Line 1: The submodule packages/web is pinned to an unreachable commit e222de8
causing check-drift to fail; merge the upstream PR lobu-ai/owletto-web#103 into
owletto-web/main first, then update the submodule pointer to the new main
commit: fetch the upstream repo, merge or rebase PR `#103` into owletto-web/main,
note the resulting commit hash on main, update the packages/web submodule
reference in this repo to that new commit (or set the submodule branch to main
and run git submodule update --init --remote), stage the submodule change and
commit so CI sees the reachable commit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| @@ -1 +1 @@ | |||
| Subproject commit 965ec489c53300230733b9f69afc4dc2298a8bda | |||
| Subproject commit e222de861a0c16887a9167c47f0ecfca5c5f2df6 | |||
There was a problem hiding this comment.
Submodule pinned to unreachable commit — CI blocked.
The check-drift pipeline failed because commit e222de8 is not reachable from owletto-web/main. The PR objectives indicate this bumps to lobu-ai/owletto-web#103, which appears to be an unmerged PR.
Merge the upstream PR #103 into owletto-web/main first, then update this submodule reference to point to the resulting commit on main.
🧰 Tools
🪛 GitHub Actions: Submodule Drift / check-drift
[error] 1-1: Pinned SHA $PINNED is not reachable from owletto-web/main. Error emitted: "Pinned SHA $PINNED is not reachable from owletto-web/main."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/web` at line 1, The submodule packages/web is pinned to an
unreachable commit e222de8 causing check-drift to fail; merge the upstream PR
lobu-ai/owletto-web#103 into owletto-web/main first, then update the submodule
pointer to the new main commit: fetch the upstream repo, merge or rebase PR `#103`
into owletto-web/main, note the resulting commit hash on main, update the
packages/web submodule reference in this repo to that new commit (or set the
submodule branch to main and run git submodule update --init --remote), stage
the submodule change and commit so CI sees the reachable commit.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![codex-approver[bot]](https://avatars.githubusercontent.com/u/255265539?s=60&v=4){kind=small}
2 participants
Summary
Bumps
packages/webto lobu-ai/owletto-web#103.The inbox was a list of pointers — every notification just navigated to the underlying event. A separate page and sidebar pill for that is dead weight. Fold notifications into the command palette where they fit the "jump to anything" mental model.
nav-shell-v2; unread badge moves onto the Search button next to itCommandPaletterenders a top "Notifications" group when input is empty + signed in + items exist; mark-read + navigate on select; "Mark all as read" row when there's anything unread/inboxroute andnotification-itemcomponentNo backwards-compat shims, no
/inbox → paletteredirect.Test plan
Summary by CodeRabbit